refactor: address comments.

Author: knightedcodemonkey

package.json

@@ -32,12 +32,12 @@
     "build:esm": "KNIGHTED_PRIMARY_CDN=esm npm run build",
     "build:jspm": "KNIGHTED_PRIMARY_CDN=jspmGa npm run build",
     "build:importmap-mode": "KNIGHTED_PRIMARY_CDN=importMap npm run build",
-    "preview": "KNIGHTED_PRIMARY_CDN=esm npm run build && http-server dist -a localhost -p 8081 -c-1 -o index.html",
+    "preview": "npm run build && http-server dist -a localhost -p 8081 -c-1 -o index.html",
     "check-types": "tsc -p tsconfig.json",
     "lint:playwright": "eslint playwright playwright.config.ts",
-    "test:e2e": "KNIGHTED_PRIMARY_CDN=esm npm run build && PLAYWRIGHT_WEB_SERVER_MODE=preview PLAYWRIGHT_PORT=8081 playwright test",
+    "test:e2e": "npm run build && PLAYWRIGHT_WEB_SERVER_MODE=preview PLAYWRIGHT_PORT=8081 playwright test",
     "test:e2e:dev": "playwright test",
-    "test:e2e:headed": "KNIGHTED_PRIMARY_CDN=esm npm run build && PLAYWRIGHT_WEB_SERVER_MODE=preview PLAYWRIGHT_PORT=8081 playwright test --headed",
+    "test:e2e:headed": "npm run build && PLAYWRIGHT_WEB_SERVER_MODE=preview PLAYWRIGHT_PORT=8081 playwright test --headed",
     "test": "echo \"Error: no test specified\" && exit 1",
     "prettier": "prettier --write .",
     "lint": "oxlint src scripts && npm run lint:playwright"

scripts/build-js.js

@@ -30,7 +30,19 @@ const collectJavaScriptFiles = async directory => {
 
   return nested.flat()
 }
-const distStats = await stat(distDir)
+let distStats
+
+try {
+  distStats = await stat(distDir)
+} catch (error) {
+  if (error && typeof error === 'object' && 'code' in error && error.code === 'ENOENT') {
+    throw new Error('dist directory is missing. Run build:prepare first.', {
+      cause: error,
+    })
+  }
+
+  throw error
+}
 
 if (!distStats.isDirectory()) {
   throw new Error('dist directory is missing. Run build:prepare first.')

scripts/build.js

@@ -11,6 +11,12 @@ const run = script => {
     env,
   })
 
+  if (result.error) {
+    throw new Error(`Failed to run npm script "${script}".`, {
+      cause: result.error,
+    })
+  }
+
   if (result.status !== 0) {
     process.exit(result.status ?? 1)
   }