fix(playwright): stabilize lint diagnostics waits with one-time rerun fallback. (#101)

Author: knightedcodemonkey

playwright/diagnostics.spec.ts

@@ -338,7 +338,11 @@ test('component lint reports missing button type prop', async ({ page }) => {
 
   await runComponentLint(page)
 
-  await waitForLintDiagnosticsIssues(page)
+  await waitForLintDiagnosticsIssues(page, {
+    rerunLint: async () => {
+      await runComponentLint(page)
+    },
+  })
   await expect(page.getByText(/a11y\/useButtonType/)).toBeVisible()
 })
 
@@ -353,7 +357,11 @@ test('styles diagnostics rows navigate editor to reported line', async ({ page }
 
   await runStylesLint(page)
 
-  await waitForLintDiagnosticsIssues(page)
+  await waitForLintDiagnosticsIssues(page, {
+    rerunLint: async () => {
+      await runStylesLint(page)
+    },
+  })
 
   const targetDiagnostic = page.getByRole('button', { name: /^L3(:\d+)?\s/ }).first()
   await expect(targetDiagnostic).toBeVisible()
@@ -371,7 +379,11 @@ test('styles lint reports CSS syntax errors', async ({ page }) => {
 
   await runStylesLint(page)
 
-  await waitForLintDiagnosticsIssues(page)
+  await waitForLintDiagnosticsIssues(page, {
+    rerunLint: async () => {
+      await runStylesLint(page)
+    },
+  })
   await expect(page.locator('#diagnostics-styles')).toContainText(
     'Biome reported issues.',
   )

playwright/helpers/app-test-helpers.ts

@@ -263,12 +263,32 @@ export const runStylesLint = async (page: Page) => {
   await page.getByRole('button', { name: 'Styles lint' }).click()
 }
 
-export const waitForLintDiagnosticsIssues = async (page: Page) => {
+export const waitForLintDiagnosticsIssues = async (
+  page: Page,
+  {
+    rerunLint,
+  }: {
+    rerunLint?: () => Promise<void>
+  } = {},
+) => {
   const diagnosticsToggle = page.getByRole('button', { name: /^Diagnostics/ })
 
-  await expect(diagnosticsToggle).toHaveAttribute('aria-busy', 'false')
-  await expect(diagnosticsToggle).toHaveClass(/diagnostics-toggle--error/)
-  await expect(page.getByText(/Rendered \(Lint issues: [1-9]\d*\)/)).toBeVisible()
+  const expectLintIssuesVisible = async () => {
+    await expect(diagnosticsToggle).toHaveAttribute('aria-busy', 'false')
+    await expect(diagnosticsToggle).toHaveClass(/diagnostics-toggle--error/)
+    await expect(page.getByText(/Rendered \(Lint issues: [1-9]\d*\)/)).toBeVisible()
+  }
+
+  try {
+    await expectLintIssuesVisible()
+  } catch (error) {
+    if (typeof rerunLint !== 'function') {
+      throw error
+    }
+
+    await rerunLint()
+    await expectLintIssuesVisible()
+  }
 
   await ensureDiagnosticsDrawerOpen(page)
   await expect(page.locator('#diagnostics-styles')).toContainText(