refactor: diagnostics per editor buffer.

Author: knightedcodemonkey

src/app.js

@@ -2450,7 +2450,7 @@ const syncLintPendingState = () => {
   setLintDiagnosticsPending(componentLintPending || stylesLintPending)
 }
 
-const runComponentLint = async ({ userInitiated = false } = {}) => {
+const runComponentLint = ({ userInitiated = false, source = undefined } = {}) => {
   activeComponentLintAbortController?.abort()
   const controller = new AbortController()
   activeComponentLintAbortController = controller
@@ -2460,24 +2460,28 @@ const runComponentLint = async ({ userInitiated = false } = {}) => {
 
   setLintButtonLoading({ button: lintComponentButton, isLoading: true })
 
-  try {
-    const result = await lintDiagnostics.lintComponent({
+  return lintDiagnostics
+    .lintComponent({
       signal: controller.signal,
       userInitiated,
+      source,
+    })
+    .then(result => {
+      if (result) {
+        lastComponentLintIssueCount = result.issueCount
+      }
+      return result
+    })
+    .finally(() => {
+      decrementLintDiagnosticsRuns()
+      if (activeComponentLintAbortController === controller) {
+        activeComponentLintAbortController = null
+        setLintButtonLoading({ button: lintComponentButton, isLoading: false })
+      }
     })
-    if (result) {
-      lastComponentLintIssueCount = result.issueCount
-    }
-  } finally {
-    decrementLintDiagnosticsRuns()
-    if (activeComponentLintAbortController === controller) {
-      activeComponentLintAbortController = null
-      setLintButtonLoading({ button: lintComponentButton, isLoading: false })
-    }
-  }
 }
 
-const runStylesLint = async ({ userInitiated = false } = {}) => {
+const runStylesLint = ({ userInitiated = false, source = undefined } = {}) => {
   activeStylesLintAbortController?.abort()
   const controller = new AbortController()
   activeStylesLintAbortController = controller
@@ -2487,21 +2491,25 @@ const runStylesLint = async ({ userInitiated = false } = {}) => {
 
   setLintButtonLoading({ button: lintStylesButton, isLoading: true })
 
-  try {
-    const result = await lintDiagnostics.lintStyles({
+  return lintDiagnostics
+    .lintStyles({
       signal: controller.signal,
       userInitiated,
+      source,
+    })
+    .then(result => {
+      if (result) {
+        lastStylesLintIssueCount = result.issueCount
+      }
+      return result
+    })
+    .finally(() => {
+      decrementLintDiagnosticsRuns()
+      if (activeStylesLintAbortController === controller) {
+        activeStylesLintAbortController = null
+        setLintButtonLoading({ button: lintStylesButton, isLoading: false })
+      }
     })
-    if (result) {
-      lastStylesLintIssueCount = result.issueCount
-    }
-  } finally {
-    decrementLintDiagnosticsRuns()
-    if (activeStylesLintAbortController === controller) {
-      activeStylesLintAbortController = null
-      setLintButtonLoading({ button: lintStylesButton, isLoading: false })
-    }
-  }
 }
 
 const markTypeDiagnosticsStale = () => {
@@ -2888,17 +2896,26 @@ if (diagnosticsClearAll) {
 }
 if (typecheckButton) {
   typecheckButton.addEventListener('click', () => {
-    typeDiagnostics.triggerTypeDiagnostics({ userInitiated: true })
+    typeDiagnostics.triggerTypeDiagnostics({
+      userInitiated: true,
+      source: getJsxSource(),
+    })
   })
 }
 if (lintComponentButton) {
   lintComponentButton.addEventListener('click', () => {
-    void runComponentLint({ userInitiated: true })
+    void runComponentLint({
+      userInitiated: true,
+      source: getJsxSource(),
+    })
   })
 }
 if (lintStylesButton) {
   lintStylesButton.addEventListener('click', () => {
-    void runStylesLint({ userInitiated: true })
+    void runStylesLint({
+      userInitiated: true,
+      source: getCssSource(),
+    })
   })
 }
 renderButton.addEventListener('click', renderPreview)

src/modules/lint-diagnostics.js

@@ -297,7 +297,11 @@ export const createLintDiagnosticsController = ({
     }
   }
 
-  const lintComponent = async ({ signal, userInitiated = false } = {}) => {
+  const lintComponent = async ({
+    signal,
+    userInitiated = false,
+    source = undefined,
+  } = {}) => {
     componentLintRunId += 1
     const runId = componentLintRunId
 
@@ -310,7 +314,7 @@ export const createLintDiagnosticsController = ({
 
     try {
       const diagnostics = await runLintDiagnostics({
-        source: getComponentSource(),
+        source: typeof source === 'string' ? source : getComponentSource(),
         path: lintPathByScope.component,
         signal,
       })
@@ -366,7 +370,11 @@ export const createLintDiagnosticsController = ({
     }
   }
 
-  const lintStyles = async ({ signal, userInitiated = false } = {}) => {
+  const lintStyles = async ({
+    signal,
+    userInitiated = false,
+    source = undefined,
+  } = {}) => {
     stylesLintRunId += 1
     const runId = stylesLintRunId
 
@@ -391,7 +399,7 @@ export const createLintDiagnosticsController = ({
             : lintPathByScope.styles
 
       const diagnostics = await runLintDiagnostics({
-        source: getStylesSource(),
+        source: typeof source === 'string' ? source : getStylesSource(),
         path,
         signal,
       })

src/modules/type-diagnostics.js

@@ -859,7 +859,10 @@ export const createTypeDiagnosticsController = ({
       .filter(diagnostic => !shouldIgnoreTypeDiagnostic(diagnostic))
   }
 
-  const runTypeDiagnostics = async (runId, { userInitiated = false } = {}) => {
+  const runTypeDiagnostics = async (
+    runId,
+    { userInitiated = false, sourceOverride = undefined } = {},
+  ) => {
     incrementTypeDiagnosticsRuns()
     setTypeDiagnosticsPending(false)
     setTypecheckButtonLoading(true)
@@ -876,7 +879,9 @@ export const createTypeDiagnosticsController = ({
         return
       }
 
-      const diagnostics = await collectTypeDiagnostics(compiler, getJsxSource())
+      const sourceForRun =
+        typeof sourceOverride === 'string' ? sourceOverride : getJsxSource()
+      const diagnostics = await collectTypeDiagnostics(compiler, sourceForRun)
       const errorCategory = compiler.DiagnosticCategory?.Error
       const errors = diagnostics.filter(
         diagnostic => diagnostic.category === errorCategory,
@@ -938,9 +943,12 @@ export const createTypeDiagnosticsController = ({
     }
   }
 
-  const triggerTypeDiagnostics = ({ userInitiated = false } = {}) => {
+  const triggerTypeDiagnostics = ({ userInitiated = false, source = undefined } = {}) => {
     typeCheckRunId += 1
-    void runTypeDiagnostics(typeCheckRunId, { userInitiated })
+    void runTypeDiagnostics(typeCheckRunId, {
+      userInitiated,
+      sourceOverride: source,
+    })
   }
 
   const scheduleTypeRecheck = () => {