feat: improved workspace ux baseline.

Author: knightedcodemonkey

docs/idb-workspace-state.md

@@ -23,7 +23,7 @@ Each workspace record may include:
   - `head`
   - `prTitle`
   - `prNumber`
-  - `prContextState` (`inactive` | `active` | `disconnected` | `closed`)
+  - `prContextState` (`inactive` | `active` | `closed`)
 - Runtime/editor state:
   - `renderMode`
   - `activeTabId`
@@ -37,7 +37,7 @@ IDB supports that by storing:
 
 - Full workspace snapshots
 - Repo-scoped context records
-- Historical transitions such as disconnected or closed PR context
+- Historical transitions such as closed PR context
 
 ## Design Rule
 

docs/issue-99-workspaces-drawer-plan.md

@@ -0,0 +1,71 @@
+# Issue #99 + Workspaces Drawer UX Plan
+
+## Goal
+
+Simplify PR/workspace lifecycle and the Workspaces drawer UX by:
+
+- removing disconnected state and Disconnect action paths
+- using workspace terminology in the drawer (not context)
+- separating new workspace initialization from workspace selection
+- preserving strict explicit intent semantics (no implicit apply/mutation from select changes)
+
+## Decisions
+
+- New workspace is an explicit direct action via a `New workspace` button.
+- `New workspace` must work for both repository scopes and `Local`.
+- `Open` remains the explicit action for applying an existing stored workspace.
+- If the selected repository has no stored workspaces, hide the workspace select and show the new-workspace path.
+
+## Implementation Steps
+
+1. Remove disconnected model paths (Issue #99)
+
+- Remove Disconnect control from UI.
+- Remove disconnected event wiring and runtime callbacks.
+- Remove disconnected public action paths.
+- Normalize legacy `disconnected` records to `inactive` during restore/normalization.
+
+2. Redesign drawer flow
+
+- Replace starter option-in-select behavior with a dedicated `New workspace` button adjacent to repository select.
+- Keep workspace select for stored workspaces only.
+- Hide workspace select when no stored workspaces exist for the selected scope.
+- Keep strict explicit selection semantics (no auto-apply from select/filter changes).
+
+3. Update copy and accessibility
+
+- Replace "Stored contexts" and related "context" wording with "Workspace" wording.
+- Update status and aria labels consistently.
+
+4. Remove obsolete code paths
+
+- Remove starter prefix constants and parsing.
+- Remove disconnected-only logic and stale styling/branches.
+
+5. Update tests
+
+- Remove/replace disconnected-focused scenarios.
+- Update helpers/selectors to new workspace labels and `New workspace` action.
+- Add/adjust scenarios for empty repository scope (select hidden) and explicit Open behavior for existing workspaces.
+
+6. Update docs
+
+- Update storage/state docs to remove disconnected semantics.
+- Update drawer UX docs to reflect repository row + new workspace action flow.
+
+## Verification
+
+1. `npm run lint`
+2. Targeted Playwright (Chromium first):
+
+- `playwright/github-pr-drawer/active-context-switch.spec.ts`
+- `playwright/github-pr-drawer/open-pr-create.spec.ts`
+
+3. Broader Playwright run for workspace/PR drawer flows.
+4. Manual verification in dev server for:
+
+- repository + new workspace row
+- local new workspace creation
+- hidden workspace select when no stored entries
+- explicit Open required for existing entries
+- no Disconnect control

docs/localstorage-state.md

@@ -19,7 +19,7 @@ Do not store pull request context in `localStorage`.
 Examples that must stay out of `localStorage`:
 
 - Selected repository preference (`owner/repo`)
-- PR context state (`active`, `disconnected`, `closed`, `inactive`)
+- PR context state (`active`, `closed`, `inactive`)
 - PR number and URL
 - PR base/head/title/body
 - PR drawer repository-scoped workflow state

docs/pr-context-storage-matrix.md

@@ -20,7 +20,7 @@ See the full storage ownership docs for non-PR keys:
 - Database: `knighted-develop-workspaces`
 - Object store: `prWorkspaces`
 - Relevant fields in each workspace record:
-  - `prContextState`: `inactive` | `active` | `disconnected` | `closed`
+  - `prContextState`: `inactive` | `active` | `closed`
   - `prNumber`: `number | null`
   - `prTitle`, `base`, `head`
   - `repo`
@@ -34,12 +34,11 @@ See the full storage ownership docs for non-PR keys:
 
 Use this matrix as the source of truth when debugging UI/storage mismatch.
 
-| Scenario                                      | IDB `prContextState` | IDB `prNumber`                    | localStorage PR fields | Notes                                                                                                          |
-| --------------------------------------------- | -------------------- | --------------------------------- | ---------------------- | -------------------------------------------------------------------------------------------------------------- |
-| A. Local workspace only, no PR context        | `inactive`           | `null`                            | none                   | No connected PR context.                                                                                       |
-| B. Workspace is for an active, open PR        | `active`             | PR number                         | none                   | Push mode in PR controls.                                                                                      |
-| C. Workspace is for a disconnected PR context | `disconnected`       | last known PR number if available | none                   | Opening this workspace from Workspaces restores PR runtime context and verifies open/closed state with GitHub. |
-| D. Workspace is for a PR closed on GitHub     | `closed`             | closed PR number                  | none                   | Historical context retained for debugging/reference.                                                           |
+| Scenario                                  | IDB `prContextState` | IDB `prNumber`   | localStorage PR fields | Notes                                                |
+| ----------------------------------------- | -------------------- | ---------------- | ---------------------- | ---------------------------------------------------- |
+| A. Local workspace only, no PR context    | `inactive`           | `null`           | none                   | No connected PR context.                             |
+| B. Workspace is for an active, open PR    | `active`             | PR number        | none                   | Push mode in PR controls.                            |
+| C. Workspace is for a PR closed on GitHub | `closed`             | closed PR number | none                   | Historical context retained for debugging/reference. |
 
 ## Current Workspace Selection On Load
 
@@ -82,9 +81,8 @@ When the UI does not match expected PR state:
    - `prNumber`
    - `repo`, `head`, `prTitle`
 2. Compare against the matrix above.
-3. If scenario C is expected, open that workspace from Workspaces to restore runtime PR context.
-4. If the PR is still open on GitHub, expect PR controls to return to Push mode and the workspace record to transition back to `active`.
-5. If the PR is no longer open, expect Open PR mode to remain and status messaging to explain verification results.
+3. If the PR is still open on GitHub, expect PR controls to return to Push mode and the workspace record to transition back to `active`.
+4. If the PR is no longer open, expect Open PR mode to remain and status messaging to explain verification results.
 
 ## Console Snippets
 
@@ -99,19 +97,13 @@ indexedDB.open('knighted-develop-workspaces').onsuccess = event => {
 }
 ```
 
-## Reconnect Behavior
-
-Reconnect behavior from the Workspaces drawer is implemented.
-
-Opening a `disconnected` workspace record restores active PR runtime context for that repository and reinitializes editor state from the selected workspace record.
-
 ## End-Of-Session Behavior
 
-`Disconnect` and `Close` are treated as end-of-session actions for PR-linked workspaces.
+`Close` is the end-of-session action for PR-linked workspaces.
 
-When either action is confirmed:
+When close is confirmed:
 
-1. The current workspace is archived as historical (`disconnected` or `closed`).
+1. The current workspace is archived as historical (`closed`).
 2. The app immediately switches to a fresh local workspace (`inactive`) with a single empty entry tab.
 3. Status messaging guides the user to continue locally or reopen a stored workspace from Workspaces.
 

playwright/github-byot-ai.spec.ts

@@ -768,21 +768,16 @@ test('BYOT remembers selected repository across reloads', async ({ page }) => {
 
   await page.getByRole('button', { name: 'Workspaces' }).click()
   const workspaceRepositoryFilter = page.getByLabel('Workspace repository filter')
-  const storedContextsSelect = page.getByLabel('Stored local editor contexts')
-  const openStoredContextButton = page.getByRole('button', {
-    name: 'Open',
+  const newWorkspaceButton = page.getByRole('button', {
+    name: 'New workspace',
     exact: true,
   })
   await expect(workspaceRepositoryFilter).toBeVisible()
   await workspaceRepositoryFilter.selectOption('knightedcodemonkey/develop')
   await expect(workspaceRepositoryFilter).toHaveValue('knightedcodemonkey/develop')
 
-  await expect(storedContextsSelect).toBeVisible()
-  await storedContextsSelect.selectOption({
-    label: 'Start new context for knightedcodemonkey/develop',
-  })
-  await expect(openStoredContextButton).toBeEnabled()
-  await openStoredContextButton.click()
+  await expect(newWorkspaceButton).toBeVisible()
+  await newWorkspaceButton.click()
   await page.getByRole('button', { name: 'Close workspaces drawer' }).click()
 
   await ensureOpenPrDrawerOpen(page)