refactor: address comments.

Author: knightedcodemonkey

src/modules/github-chat-drawer/drawer.js

@@ -105,7 +105,6 @@ export const createGitHubChatDrawer = ({
         continue
       }
 
-      message.confirmTarget = null
       message.appliedTargets = null
     }
   }
@@ -881,15 +880,15 @@ export const createGitHubChatDrawer = ({
   renderMessages()
   setChatStatus('Idle', 'neutral')
 
-  toggleButton?.addEventListener('click', () => {
+  const onToggleButtonClick = () => {
     setOpen(!open)
-  })
+  }
 
-  closeButton?.addEventListener('click', () => {
+  const onCloseButtonClick = () => {
     setOpen(false)
-  })
+  }
 
-  clearButton?.addEventListener('click', () => {
+  const onClearButtonClick = () => {
     stopPendingRequest()
     setPendingState(false)
     cancelPendingAssistantBodyUpdate()
@@ -898,9 +897,9 @@ export const createGitHubChatDrawer = ({
     messages.length = 0
     renderMessages()
     setChatStatus('Chat cleared.', 'neutral')
-  })
+  }
 
-  drawer?.addEventListener('click', event => {
+  const onDrawerClick = event => {
     const target = event.target
     if (!(target instanceof HTMLElement)) {
       return
@@ -1002,27 +1001,33 @@ export const createGitHubChatDrawer = ({
       renderMessages()
       return
     }
-  })
+  }
 
-  sendButton?.addEventListener('click', () => {
+  const onSendButtonClick = () => {
     void runChatRequest()
-  })
+  }
 
-  promptInput?.addEventListener('keydown', event => {
+  const onPromptInputKeydown = event => {
     if (event.key !== 'Enter' || (!event.metaKey && !event.ctrlKey)) {
       return
     }
 
     event.preventDefault()
     void runChatRequest()
-  })
+  }
 
   const onDocumentKeydown = event => {
     if (event.key === 'Escape' && open) {
       setOpen(false)
     }
   }
 
+  toggleButton?.addEventListener('click', onToggleButtonClick)
+  closeButton?.addEventListener('click', onCloseButtonClick)
+  clearButton?.addEventListener('click', onClearButtonClick)
+  drawer?.addEventListener('click', onDrawerClick)
+  sendButton?.addEventListener('click', onSendButtonClick)
+  promptInput?.addEventListener('keydown', onPromptInputKeydown)
   document.addEventListener('keydown', onDocumentKeydown)
 
   return {
@@ -1044,6 +1049,12 @@ export const createGitHubChatDrawer = ({
         undoActionsNode.remove()
         undoActionsNode = null
       }
+      toggleButton?.removeEventListener('click', onToggleButtonClick)
+      closeButton?.removeEventListener('click', onCloseButtonClick)
+      clearButton?.removeEventListener('click', onClearButtonClick)
+      drawer?.removeEventListener('click', onDrawerClick)
+      sendButton?.removeEventListener('click', onSendButtonClick)
+      promptInput?.removeEventListener('keydown', onPromptInputKeydown)
       document.removeEventListener('keydown', onDocumentKeydown)
     },
   }

src/modules/github-chat-drawer/payload.js

@@ -58,14 +58,26 @@ const mergeConversationSummary = ({ existingSummary, droppedMessages }) => {
   return `${merged.slice(0, chatMaxSummaryChars)}...`
 }
 
+const toModeDisplayText = value => {
+  const mode = toChatText(value)
+  return mode || 'unknown'
+}
+
+const toModeKey = value => toChatText(value).toLowerCase()
+
 const collectModePolicyContext = ({ renderMode, styleMode }) => {
+  const renderModeText = toModeDisplayText(renderMode)
+  const styleModeText = toModeDisplayText(styleMode)
+  const renderModeKey = toModeKey(renderMode)
+  const styleModeKey = toModeKey(styleMode)
+
   const policyLines = [
     'Mode-aware policy:',
-    `- Render mode: ${renderMode || 'unknown'}`,
-    `- Style mode: ${styleMode || 'unknown'}`,
+    `- Render mode: ${renderModeText}`,
+    `- Style mode: ${styleModeText}`,
   ]
 
-  if (renderMode.toLowerCase() === 'dom') {
+  if (renderModeKey === 'dom') {
     policyLines.push(
       '- In DOM mode, avoid React hook/state guidance unless the user explicitly asks for React migration.',
     )
@@ -74,11 +86,11 @@ const collectModePolicyContext = ({ renderMode, styleMode }) => {
     )
   }
 
-  if (renderMode.toLowerCase() === 'react') {
+  if (renderModeKey === 'react') {
     policyLines.push('- In React mode, prefer component-based React guidance.')
   }
 
-  if (styleMode.toLowerCase() === 'css') {
+  if (styleModeKey === 'css') {
     policyLines.push(
       '- Keep style advice compatible with plain CSS unless user asks for a preprocessor.',
     )