Skip to content

refactor: remove collapsible editors and update breakpoint styles.#113

Merged
knightedcodemonkey merged 4 commits intonextfrom
bananas
May 2, 2026
Merged

refactor: remove collapsible editors and update breakpoint styles.#113
knightedcodemonkey merged 4 commits intonextfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings May 2, 2026 14:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the ability to collapse the component/styles editor panels (keeping preview collapse only) and modernizes responsive breakpoint styling by switching media queries to the CSS range syntax, with a small mobile grid tweak to consistently allocate the workspace-context row.

Changes:

  • Removed component/styles collapse buttons and the associated collapse CSS, leaving preview as the only collapsible panel.
  • Simplified layout collapse logic in layout-diagnostics-setup to manage preview-only collapse state.
  • Updated responsive CSS breakpoints from max-width to (width <= …) and adjusted the mobile grid template to include the workspace-context area.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/styles/preview-controls.css Updates small-screen breakpoint to (width <= 480px) syntax.
src/styles/panels-editor.css Removes editor collapse styling and updates 900px breakpoint syntax.
src/styles/layout-shell.css Updates breakpoint syntax and refines mobile grid rows/areas (adds workspace-context row).
src/styles/dialogs-overlays.css Updates 900px breakpoints to range syntax.
src/styles/diagnostics.css Updates 900px breakpoint to range syntax.
src/styles/base.css Updates 900px breakpoint to range syntax for body overflow/height behavior.
src/styles/ai-controls.css Updates 1090px/900px breakpoints to range syntax.
src/modules/app-core/layout-diagnostics-setup.js Refactors collapse behavior to preview-only and removes editor collapse state management.
src/index.html Removes collapse buttons for component/styles panels.
playwright/workspace-tabs.spec.ts Removes a now-invalid interaction with the component collapse button.
playwright/layout-panels.spec.ts Updates expectations to confirm editor collapse controls are gone and validates preview collapse only.
playwright/helpers/app-test-helpers.ts Narrows collapse helpers to preview-only.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/modules/app-core/layout-diagnostics-setup.js
@knightedcodemonkey knightedcodemonkey merged commit e252217 into next May 2, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch May 2, 2026 14:51
knightedcodemonkey added a commit that referenced this pull request May 2, 2026
* feat: idb infrastructure. (#63)

* feat: dynamic tabs. (#64)

* refactor: better accessbility for tabs. (#68)

* feat: remove allow-same-origin for better security. (#69)

* feat: tab reordering via drag-n-drop. (#70)

* feat: explicit css imports, diagnostics per editor buffer. (#71)

* feat: idb + github sync with atomic open and push to remote. (#78)

* closes #73, closes #74, closes #75.

* refactor: more colocation and smaller file sizes. (#79)

* refactor: improvements with styles and gh syncs. (#82)

* test: webkit flake. (#83)

* test: address flake. (#84)

* refactor: github pr context. (#85)

* fix: require app in entry, hide workspaces without pat, remove star important. (#86)

* feat: make idb source of truth for pr context. (#87)

* fix: active pr context on reload and dedupe workspace identity. (#88)

* fix: edited and push sync across reloads. (#89)

* fix: properly commit tab name changes. (#90)

* fix(tabs): filename edits, min-widths, scrolling, content sync. (#91)

* feat: improved workspace disconnect and closed ux. (#92)

* refactor: status styling and biome config. (#94)

* fix(diagnostics): enforce current-editor snapshots and stale results. (#95)

* fix: consistent head handling. (#96)

* fix: prevent workspace overwrites. (#100)

* fix(playwright): stabilize lint diagnostics waits with one-time rerun fallback. (#101)

* feat: improved workspace ux and state identity separation.  (#103)

* fix: iframe protocol mismatch in receiver reads. (#104)

* refactor: remove remaining fixed editor assumptions. (#105)

* refactor: simplify PR close flow with deterministic workspace state updates (#106)

* feat: mode-aware entry tab extensions. (#108)

* feat: workspace status bar. (#109)

* feat: tab-scoped ai chat. (#111)

* refactor: better workspace drawer ux. (#112)

* refactor: remove collapsible editors and update breakpoint styles. (#113)

* docs: update for vnext. (#114)

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants