Skip to content

fix: delete removed tabs when pushing.#122

Merged
knightedcodemonkey merged 3 commits intomainfrom
bananas
May 2, 2026
Merged

fix: delete removed tabs when pushing.#122
knightedcodemonkey merged 3 commits intomainfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

Copilot AI review requested due to automatic review settings May 2, 2026 18:06
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the workspace sync/push flow so that removing a previously-synced tab results in a delete entry being included in the next “push commit” to an active PR. It also updates CI config to stop running the Playwright workflow on the next branch (per #119).

Changes:

  • Track removed synced tabs and include delete updates for their paths when pushing commits to an active PR.
  • Add Playwright coverage to validate delete entries are shown and sent to the Git Trees API after a tab is removed.
  • Update the Playwright GitHub Actions workflow to no longer run on pull requests targeting next.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/modules/app-core/workspace-tab-mutations-controller.js Hooks tab removal to track deleted paths before pushing.
src/modules/app-core/workspace-sync-controller.js Stores removed paths per workspace and emits delete entries during push; clears tracked deletions after push updates.
src/modules/app-core/workspace-controllers-setup.js Threads the new trackRemovedWorkspaceTab dependency through controller setup.
src/app.js Wires trackRemovedWorkspaceTab to the sync controller implementation.
playwright/github-pr-drawer/active-context-sync.spec.ts Adds an E2E test asserting removed synced module tabs are pushed as delete entries.
.github/workflows/playwright.yml Removes the next branch from PR triggers.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/modules/app-core/workspace-tab-mutations-controller.js
Comment thread src/modules/app-core/workspace-sync-controller.js
Comment thread .github/workflows/playwright.yml
@knightedcodemonkey knightedcodemonkey merged commit c161177 into main May 2, 2026
6 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch May 2, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the playwright run on the next branch.

2 participants