fix: delete removed tabs when pushing.#122
Merged
knightedcodemonkey merged 3 commits intomainfrom May 2, 2026
Merged
Conversation
Owner
knightedcodemonkey
commented
May 2, 2026
- ci: no runs on next branch.
- closes Remove the playwright run on the next branch. #119
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workspace sync/push flow so that removing a previously-synced tab results in a delete entry being included in the next “push commit” to an active PR. It also updates CI config to stop running the Playwright workflow on the next branch (per #119).
Changes:
- Track removed synced tabs and include delete updates for their paths when pushing commits to an active PR.
- Add Playwright coverage to validate delete entries are shown and sent to the Git Trees API after a tab is removed.
- Update the Playwright GitHub Actions workflow to no longer run on pull requests targeting
next.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/app-core/workspace-tab-mutations-controller.js | Hooks tab removal to track deleted paths before pushing. |
| src/modules/app-core/workspace-sync-controller.js | Stores removed paths per workspace and emits delete entries during push; clears tracked deletions after push updates. |
| src/modules/app-core/workspace-controllers-setup.js | Threads the new trackRemovedWorkspaceTab dependency through controller setup. |
| src/app.js | Wires trackRemovedWorkspaceTab to the sync controller implementation. |
| playwright/github-pr-drawer/active-context-sync.spec.ts | Adds an E2E test asserting removed synced module tabs are pushed as delete entries. |
| .github/workflows/playwright.yml | Removes the next branch from PR triggers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.