Skip to content

feat: auto open diagnostics on error.#20

Merged
knightedcodemonkey merged 1 commit into
mainfrom
bananas
Mar 21, 2026
Merged

feat: auto open diagnostics on error.#20
knightedcodemonkey merged 1 commit into
mainfrom
bananas

Conversation

@knightedcodemonkey

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings March 21, 2026 14:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the diagnostics UX by automatically opening the diagnostics drawer when a user-initiated lint/typecheck run finds issues, and updates UI styling/tests to match.

Changes:

  • Adjust mobile positioning of the diagnostics drawer to sit closer to the viewport bottom.
  • Add a userInitiated flag + onIssuesDetected callback to lint/type diagnostics controllers, and wire them in app.js to open the drawer on detected issues.
  • Update Playwright tests to use helpers for drawer open/close and to assert the new auto-open behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/styles/diagnostics.css Tweaks small-viewport drawer positioning (bottom: 12px).
src/modules/type-diagnostics.js Adds onIssuesDetected + userInitiated plumbing and triggers callback when user-initiated type errors are found.
src/modules/lint-diagnostics.js Adds onIssuesDetected + userInitiated plumbing and triggers callback when user-initiated lint issues are found.
src/app.js Hooks onIssuesDetected to open the diagnostics drawer; marks button-driven runs as user-initiated.
playwright/app.spec.ts Refactors drawer interactions into helpers and updates expectations for auto-open behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit b62a722 into main Mar 21, 2026
5 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch March 21, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants