feat: auto open diagnostics on error.#20
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the diagnostics UX by automatically opening the diagnostics drawer when a user-initiated lint/typecheck run finds issues, and updates UI styling/tests to match.
Changes:
- Adjust mobile positioning of the diagnostics drawer to sit closer to the viewport bottom.
- Add a
userInitiatedflag +onIssuesDetectedcallback to lint/type diagnostics controllers, and wire them inapp.jsto open the drawer on detected issues. - Update Playwright tests to use helpers for drawer open/close and to assert the new auto-open behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/diagnostics.css | Tweaks small-viewport drawer positioning (bottom: 12px). |
| src/modules/type-diagnostics.js | Adds onIssuesDetected + userInitiated plumbing and triggers callback when user-initiated type errors are found. |
| src/modules/lint-diagnostics.js | Adds onIssuesDetected + userInitiated plumbing and triggers callback when user-initiated lint issues are found. |
| src/app.js | Hooks onIssuesDetected to open the diagnostics drawer; marks button-driven runs as user-initiated. |
| playwright/app.spec.ts | Refactors drawer interactions into helpers and updates expectations for auto-open behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.