feat: explicit css imports, diagnostics per editor buffer. - #71
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the playground’s preview pipeline to require explicit stylesheet imports from the workspace module graph, and refines diagnostics to run against the active editor buffer content.
Changes:
- Require preview CSS to be included only when a styles tab is explicitly imported from the entry/module graph (including nested imports).
- Enhance typecheck/lint triggers to operate on the current editor buffer and improve TypeScript module resolution across workspace tabs.
- Add UI behavior + E2E coverage for entry-tab-only render mode changes, style-mode persistence, and deterministic graph/error behavior on tab renames.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/layout-shell.css | Prevent vertical scrolling in the layout shell strip by hiding overflow-y. |
| src/modules/type-diagnostics.js | Use workspace tabs for typecheck context; add per-run source override; improve JS→TS(X) resolution and script kinds. |
| src/modules/render-runtime.js | Compile styles from explicitly imported style tabs via the workspace graph; surface Sass warnings; remove implicit CSS sourcing. |
| src/modules/preview-runtime/virtual-workspace-modules.js | Add workspace style import resolution and strip style imports from executable JS while tracking included style tabs. |
| src/modules/lint-diagnostics.js | Allow lint runs to accept explicit source overrides (per active buffer). |
| src/modules/defaults.js | Add an explicit default CSS import in the default JSX starter source. |
| src/app.js | Wire workspace tabs into type diagnostics; adjust lint/typecheck triggers to pass active-buffer source; update render-mode editability + rerender behaviors. |
| playwright/workspace-tabs.spec.ts | Add test ensuring render mode can only be changed from the entry tab. |
| playwright/rendering-modes.spec.ts | Add tests for explicit style import behavior, nested style imports, persistence, and rename-driven graph error surfacing. |
| playwright/diagnostics.spec.ts | Add tests for JS-specifier→TSX workspace resolution and Sass warnings surfacing in diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
knightedcodemonkey
added a commit
that referenced
this pull request
May 2, 2026
* feat: idb infrastructure. (#63) * feat: dynamic tabs. (#64) * refactor: better accessbility for tabs. (#68) * feat: remove allow-same-origin for better security. (#69) * feat: tab reordering via drag-n-drop. (#70) * feat: explicit css imports, diagnostics per editor buffer. (#71) * feat: idb + github sync with atomic open and push to remote. (#78) * closes #73, closes #74, closes #75. * refactor: more colocation and smaller file sizes. (#79) * refactor: improvements with styles and gh syncs. (#82) * test: webkit flake. (#83) * test: address flake. (#84) * refactor: github pr context. (#85) * fix: require app in entry, hide workspaces without pat, remove star important. (#86) * feat: make idb source of truth for pr context. (#87) * fix: active pr context on reload and dedupe workspace identity. (#88) * fix: edited and push sync across reloads. (#89) * fix: properly commit tab name changes. (#90) * fix(tabs): filename edits, min-widths, scrolling, content sync. (#91) * feat: improved workspace disconnect and closed ux. (#92) * refactor: status styling and biome config. (#94) * fix(diagnostics): enforce current-editor snapshots and stale results. (#95) * fix: consistent head handling. (#96) * fix: prevent workspace overwrites. (#100) * fix(playwright): stabilize lint diagnostics waits with one-time rerun fallback. (#101) * feat: improved workspace ux and state identity separation. (#103) * fix: iframe protocol mismatch in receiver reads. (#104) * refactor: remove remaining fixed editor assumptions. (#105) * refactor: simplify PR close flow with deterministic workspace state updates (#106) * feat: mode-aware entry tab extensions. (#108) * feat: workspace status bar. (#109) * feat: tab-scoped ai chat. (#111) * refactor: better workspace drawer ux. (#112) * refactor: remove collapsible editors and update breakpoint styles. (#113) * docs: update for vnext. (#114) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.