refactor: improvements with styles and gh syncs.#82
Merged
Conversation
knightedcodemonkey
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub PR workflow and “edited/dirty” UX by conditionally showing “Edited” indicators only in an active PR context, adjusting commit defaults/selection for open vs push-commit flows, and normalizing trailing newlines after publish to keep local/editor state aligned with what gets committed.
Changes:
- Add “Edited” indicators (panel header label + tab dot) gated by token + active PR context.
- Change PR drawer behavior: default “Include entry tab” on, and only include dirty/uncommitted files for push-commit mode.
- Normalize/persist PR context metadata in workspace snapshots and normalize trailing newlines after publish/commit.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/panels-editor.css | Styles for header “Edited” status and tab dirty dot indicator. |
| src/modules/workspace/workspace-storage.js | Normalizes persisted prContextState in workspace records. |
| src/modules/github/github-pr-drawer.js | Push/open PR commit selection changes; default include-entry on; ensure trailing newline in committed blobs; updated empty-commit status. |
| src/modules/app-core/workspace-tabs-renderer.js | Renders dirty dot indicator (now conditional via getShouldShowEditedDesign). |
| src/modules/app-core/workspace-tab-mutations-controller.js | Marks newly created tabs dirty in active PR context (for Edited indicator). |
| src/modules/app-core/workspace-sync-controller.js | Adds options to include all files vs only dirty/uncommitted; persists PR number/state in workspace snapshot. |
| src/modules/app-core/workspace-local-helpers.js | Includes PR number and prContextState in workspace context snapshots. |
| src/modules/app-core/workspace-editor-helpers.js | Syncs header “Edited” status element visibility based on dirty state + gating. |
| src/modules/app-core/workspace-controllers-setup.js | Wires getShouldShowEditedDesign through controllers. |
| src/modules/app-core/publish-trailing-newline-normalizer.js | New helper to normalize trailing newlines in editors/tabs after publish. |
| src/modules/app-core/github-workflows.js | Adds PR context lifecycle callbacks (state change/closed/disconnected). |
| src/modules/app-core/github-workflows-setup.js | Wires new PR context callbacks from runtime. |
| src/modules/app-core/edited-indicator-visibility-controller.js | New controller to decide whether to show Edited indicators and trigger UI refresh. |
| src/index.html | Adds header “Edited” status nodes; updates include-entry checkbox label + default checked. |
| src/app.js | Integrates edited-indicator visibility + trailing-newline normalizer; persists PR context state; updates workspace commit getter signature. |
| playwright/workspace-tabs.spec.ts | Updates expectations around dirty state being local without Edited indicators. |
| playwright/github-pr-drawer.spec.ts | Adds coverage for trailing newline normalization and push-commit “no changes” status; updates include-entry default behavior. |
| AGENTS.md | Adds guidance to prefer modular/co-located architecture. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
knightedcodemonkey
added a commit
that referenced
this pull request
May 2, 2026
* feat: idb infrastructure. (#63) * feat: dynamic tabs. (#64) * refactor: better accessbility for tabs. (#68) * feat: remove allow-same-origin for better security. (#69) * feat: tab reordering via drag-n-drop. (#70) * feat: explicit css imports, diagnostics per editor buffer. (#71) * feat: idb + github sync with atomic open and push to remote. (#78) * closes #73, closes #74, closes #75. * refactor: more colocation and smaller file sizes. (#79) * refactor: improvements with styles and gh syncs. (#82) * test: webkit flake. (#83) * test: address flake. (#84) * refactor: github pr context. (#85) * fix: require app in entry, hide workspaces without pat, remove star important. (#86) * feat: make idb source of truth for pr context. (#87) * fix: active pr context on reload and dedupe workspace identity. (#88) * fix: edited and push sync across reloads. (#89) * fix: properly commit tab name changes. (#90) * fix(tabs): filename edits, min-widths, scrolling, content sync. (#91) * feat: improved workspace disconnect and closed ux. (#92) * refactor: status styling and biome config. (#94) * fix(diagnostics): enforce current-editor snapshots and stale results. (#95) * fix: consistent head handling. (#96) * fix: prevent workspace overwrites. (#100) * fix(playwright): stabilize lint diagnostics waits with one-time rerun fallback. (#101) * feat: improved workspace ux and state identity separation. (#103) * fix: iframe protocol mismatch in receiver reads. (#104) * refactor: remove remaining fixed editor assumptions. (#105) * refactor: simplify PR close flow with deterministic workspace state updates (#106) * feat: mode-aware entry tab extensions. (#108) * feat: workspace status bar. (#109) * feat: tab-scoped ai chat. (#111) * refactor: better workspace drawer ux. (#112) * refactor: remove collapsible editors and update breakpoint styles. (#113) * docs: update for vnext. (#114) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.