fix: require app in entry, hide workspaces without pat, remove star important. - #86
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens the preview entry contract to require an explicit App component, adjusts GitHub/BYOT UI visibility (notably hiding Workspaces until a PAT is available), and removes !important from [hidden] CSS rules while updating Playwright coverage to match the new behavior.
Changes:
- Remove auto-render “implicit App” wrapping so missing
Appconsistently surfaces an App-only error. - Hide Workspaces controls by default and drive toggle visibility via PAT/PR-context state.
- Simplify
[hidden]CSS rules (drop!important) and update Playwright helpers/tests for the new UI/runtime behavior.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/styles/diagnostics.css | Adds [hidden] handling for .diagnostics-toggle. |
| src/styles/ai-controls.css | Removes !important from multiple [hidden] rules; adds additional toggle hidden selectors. |
| src/modules/preview/render-runtime.js | Removes implicit-App auto-render wrapping and related JSX top-level metadata logic. |
| src/modules/app-core/workspace-tabs-renderer.js | Removes editor sync call from workspace tabs rendering flow. |
| src/modules/app-core/workspace-controllers-setup.js | Removes the now-unneeded delegate wiring for editor sync from active tab. |
| src/modules/app-core/github-workflows.js | Stops directly hiding Workspaces toggle on PR context change (delegates to PR context UI). |
| src/modules/app-core/github-pr-context-ui.js | Uses .hidden property to show/hide toggles and incorporates Workspaces visibility rules. |
| src/index.html | Sets Workspaces toggle to hidden by default. |
| playwright/rendering-modes.spec.ts | Updates expectations: auto-render no longer implicitly creates App; tests now expect App-only error unless App is explicit. |
| playwright/helpers/app-test-helpers.ts | Adds a more robust editor content replacement helper and waits for editor regions to be visible. |
| playwright/github-byot-ai.spec.ts | Adds assertions for Workspaces toggle hidden/visible states based on token connection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
knightedcodemonkey
added a commit
that referenced
this pull request
May 2, 2026
* feat: idb infrastructure. (#63) * feat: dynamic tabs. (#64) * refactor: better accessbility for tabs. (#68) * feat: remove allow-same-origin for better security. (#69) * feat: tab reordering via drag-n-drop. (#70) * feat: explicit css imports, diagnostics per editor buffer. (#71) * feat: idb + github sync with atomic open and push to remote. (#78) * closes #73, closes #74, closes #75. * refactor: more colocation and smaller file sizes. (#79) * refactor: improvements with styles and gh syncs. (#82) * test: webkit flake. (#83) * test: address flake. (#84) * refactor: github pr context. (#85) * fix: require app in entry, hide workspaces without pat, remove star important. (#86) * feat: make idb source of truth for pr context. (#87) * fix: active pr context on reload and dedupe workspace identity. (#88) * fix: edited and push sync across reloads. (#89) * fix: properly commit tab name changes. (#90) * fix(tabs): filename edits, min-widths, scrolling, content sync. (#91) * feat: improved workspace disconnect and closed ux. (#92) * refactor: status styling and biome config. (#94) * fix(diagnostics): enforce current-editor snapshots and stale results. (#95) * fix: consistent head handling. (#96) * fix: prevent workspace overwrites. (#100) * fix(playwright): stabilize lint diagnostics waits with one-time rerun fallback. (#101) * feat: improved workspace ux and state identity separation. (#103) * fix: iframe protocol mismatch in receiver reads. (#104) * refactor: remove remaining fixed editor assumptions. (#105) * refactor: simplify PR close flow with deterministic workspace state updates (#106) * feat: mode-aware entry tab extensions. (#108) * feat: workspace status bar. (#109) * feat: tab-scoped ai chat. (#111) * refactor: better workspace drawer ux. (#112) * refactor: remove collapsible editors and update breakpoint styles. (#113) * docs: update for vnext. (#114) Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.