Use mergedOptions for query params

Author: mattmikolay

packages/client/src/clients/feed/feed.ts

@@ -543,7 +543,7 @@ class Feed {
 
     const mergedOptions = {
       ...this.defaultOptions,
-      ...options,
+      ...mergeDateRangeParams(options),
       exclude: mergeAndDedupeArrays(
         this.defaultOptions.exclude,
         options.exclude,
@@ -552,15 +552,14 @@ class Feed {
 
     // trigger_data should be a JSON string for the API
     // this function will format the trigger data if it's an object
-    // https://docs.knock.app/reference#get-feed
+    // https://docs.knock.app/api-reference/users/feeds/list_items
     const formattedTriggerData = getFormattedTriggerData(mergedOptions);
 
     const formattedExclude = getFormattedExclude(mergedOptions);
 
     // Always include the default params, if they have been set
     const queryParams: FetchFeedOptionsForRequest = {
-      ...this.defaultOptions,
-      ...mergeDateRangeParams(options),
+      ...mergedOptions,
       trigger_data: formattedTriggerData,
       exclude: formattedExclude,
       // Unset options that should not be sent to the API

packages/client/src/clients/feed/interfaces.ts

@@ -68,8 +68,11 @@ export type FetchFeedOptions = {
   __fetchSource?: "socket" | "http";
 } & Omit<FeedClientOptions, "__experimentalCrossBrowserUpdates">;
 
-// The final data shape that is sent to the API
-// Should match types here: https://docs.knock.app/reference#get-feed
+/**
+ * The final data shape that is sent to the the list feed items endpoint of the Knock API.
+ *
+ * @see https://docs.knock.app/api-reference/users/feeds/list_items
+ */
 export type FetchFeedOptionsForRequest = Omit<
   FeedClientOptions,
   "trigger_data" | "exclude"
@@ -78,6 +81,10 @@ export type FetchFeedOptionsForRequest = Omit<
   trigger_data?: string;
   /** Fields to exclude from the response, joined by commas. */
   exclude?: string;
+  "inserted_at.gte"?: string;
+  "inserted_at.lte"?: string;
+  "inserted_at.gt"?: string;
+  "inserted_at.lt"?: string;
   // Unset options that should not be sent to the API
   __loadingType: undefined;
   __fetchSource: undefined;