feat: add activatable status indicator to toolbar v2#847
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
67f3bd1 to
bedf313
Compare
89d2bfa to
a415e75
Compare
a415e75 to
b5369e6
Compare
bedf313 to
07cd540
Compare
07cd540 to
e2af205
Compare
b5369e6 to
0a38e96
Compare
0c88894 to
559d59c
Compare
559d59c to
8c519c1
Compare
3a56f71 to
5308540
Compare
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| if ( | ||
| displayOption === "current-page" && | ||
| (!guide.annotation.isEligible || !guide.annotation.isQualified) | ||
| ) { |
There was a problem hiding this comment.
Current-page filter overstates displayable guides
Medium Severity
The new current-page branch filters by guide.annotation.isEligible and guide.annotation.isQualified, but those annotations do not include the guide.steps.every((s) => !!s.message.archived_at) exclusion used by selection logic. This can show guides as “Displayable on current page” even when all steps are archived and they cannot actually render.
Additional Locations (1)
There was a problem hiding this comment.
Not an issue in this PR, as it will be captured in isEligible. It is a valid point for any new engagement interactions during a debug/toolbar session, but I want to tackle that as a separate PR.
| </Stack> | ||
|
|
||
| <Stack justify="flex-end"> | ||
| {!isUnknownGuide(guide) && ( |
There was a problem hiding this comment.
Uber nit: Feels like these could be grouped together w/ a single !isUnknownGuide(guide) check
There was a problem hiding this comment.
Yep you are right, will update.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #847 +/- ##
==========================================
- Coverage 67.34% 67.17% -0.18%
==========================================
Files 203 203
Lines 8461 8505 +44
Branches 1101 1104 +3
==========================================
+ Hits 5698 5713 +15
- Misses 2738 2767 +29
Partials 25 25
|



Description
Following up to #846, this PR adds an activation status to guide's annotation, and surfaced in
GuideRow.Screenshots or videos
CleanShot.2026-02-12.at.15.58.26.mp4