Skip to content

feat: add activatable status indicator to toolbar v2#847

Merged
thomaswhyyou merged 11 commits into
mainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-7
Feb 13, 2026
Merged

feat: add activatable status indicator to toolbar v2#847
thomaswhyyou merged 11 commits into
mainfrom
thomas-kno-11142-sdk-guide-toolbar-v2-poc-7

Conversation

@thomaswhyyou
Copy link
Copy Markdown
Contributor

@thomaswhyyou thomaswhyyou commented Feb 2, 2026

Description

Following up to #846, this PR adds an activation status to guide's annotation, and surfaced in GuideRow.

Screenshots or videos

CleanShot.2026-02-12.at.15.58.26.mp4

@linear
Copy link
Copy Markdown

linear Bot commented Feb 2, 2026

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 13, 2026 6:55pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 13, 2026 6:55pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 13, 2026 6:55pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 13, 2026 6:55pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 2, 2026

⚠️ No Changeset found

Latest commit: 1f3c0f5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 67f3bd1 to bedf313 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from 89d2bfa to a415e75 Compare February 2, 2026 20:10
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from a415e75 to b5369e6 Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from bedf313 to 07cd540 Compare February 2, 2026 21:34
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-7 branch from 07cd540 to e2af205 Compare February 3, 2026 19:09
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11142-sdk-guide-toolbar-v2-poc-6 branch from b5369e6 to 0a38e96 Compare February 3, 2026 19:09
@thomaswhyyou
Copy link
Copy Markdown
Contributor Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

if (
displayOption === "current-page" &&
(!guide.annotation.isEligible || !guide.annotation.isQualified)
) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-page filter overstates displayable guides

Medium Severity

The new current-page branch filters by guide.annotation.isEligible and guide.annotation.isQualified, but those annotations do not include the guide.steps.every((s) => !!s.message.archived_at) exclusion used by selection logic. This can show guides as “Displayable on current page” even when all steps are archived and they cannot actually render.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an issue in this PR, as it will be captured in isEligible. It is a valid point for any new engagement interactions during a debug/toolbar session, but I want to tackle that as a separate PR.

</Stack>

<Stack justify="flex-end">
{!isUnknownGuide(guide) && (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uber nit: Feels like these could be grouped together w/ a single !isUnknownGuide(guide) check

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep you are right, will update.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 13, 2026

Codecov Report

❌ Patch coverage is 38.77551% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.17%. Comparing base (ddd7981) to head (1f3c0f5).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 8.69% 21 Missing ⚠️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 0.00% 7 Missing ⚠️
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #847      +/-   ##
==========================================
- Coverage   67.34%   67.17%   -0.18%     
==========================================
  Files         203      203              
  Lines        8461     8505      +44     
  Branches     1101     1104       +3     
==========================================
+ Hits         5698     5713      +15     
- Misses       2738     2767      +29     
  Partials       25       25              
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 88.92% <100.00%> (+0.07%) ⬆️
packages/client/src/clients/guide/index.ts 100.00% <100.00%> (ø)
...omponents/Toolbar/V2/useInspectGuideClientStore.ts 100.00% <100.00%> (ø)
.../components/Toolbar/V2/GuidesListDisplaySelect.tsx 13.63% <0.00%> (-1.37%) ⬇️
...act/src/modules/guide/components/Toolbar/V2/V2.tsx 14.89% <0.00%> (-1.02%) ⬇️
...c/modules/guide/components/Toolbar/V2/GuideRow.tsx 10.57% <8.69%> (-2.68%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants