Skip to content

feat(KNO-11394): initialize feed clients in compact mode by default#851

Merged
mattmikolay merged 18 commits into
mainfrom
mattmik-kno-11394-support-compact-mode-for-feeds
Feb 10, 2026
Merged

feat(KNO-11394): initialize feed clients in compact mode by default#851
mattmikolay merged 18 commits into
mainfrom
mattmik-kno-11394-support-compact-mode-for-feeds

Conversation

@mattmikolay

@mattmikolay mattmikolay commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Description

This PR updates the feed client so that it supports a new option mode, which can be set to either "compact" or "rich". When set to "compact", the activities and total_activities fields will not be present on feed items returned via the API; the data field will not include nested arrays and objects; and the actors field will only have up to a single actor.

By default, mode will be set to "compact". Thus, these changes constitute a minor version bump.

Note that neither activities nor total_activities are used by our in-app feed components out-of-the-box.

Todos

  • Merge knocklabs/switchboard#5467
  • Merge knocklabs/switchboard#5478

Checklist

  • Tests have been added for new features or major refactors to existing features.

Screenshots or videos

https://www.loom.com/share/db52cdeee7ad4407b3dd6ea907e86ce9

@linear

linear Bot commented Feb 3, 2026

Copy link
Copy Markdown

@vercel

vercel Bot commented Feb 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Feb 10, 2026 8:19pm
javascript-nextjs-example Ready Ready Preview, Comment Feb 10, 2026 8:19pm
javascript-slack-connect-example Ready Ready Preview, Comment Feb 10, 2026 8:19pm
javascript-slack-kit-example Ready Ready Preview, Comment Feb 10, 2026 8:19pm

Request Review

@changeset-bot

changeset-bot Bot commented Feb 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 87c4b43

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@knocklabs/client Minor
@knocklabs/react-core Minor
@knocklabs/expo Minor
@knocklabs/react Minor
@knocklabs/react-native Minor
client-example Patch
guide-example Patch
@knocklabs/expo-example Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

mattmikolay commented Feb 3, 2026

Copy link
Copy Markdown
Contributor Author

@mattmikolay

Copy link
Copy Markdown
Contributor Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Comment thread packages/client/test/clients/feed/feed.test.ts Outdated
"@knocklabs/react-native": minor
---

Initialize feeds in `"compact"` mode by default

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like there may be a potential breakage if you upgrade without any code change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct. As per Chris’s comment here:

We'll need to mark this as a breaking change, which for us means a minor release (pre 1.0)

@codecov

codecov Bot commented Feb 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.45%. Comparing base (61fccaa) to head (87c4b43).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #851   +/-   ##
=======================================
  Coverage   68.45%   68.45%           
=======================================
  Files         193      193           
  Lines        8061     8062    +1     
  Branches     1065     1065           
=======================================
+ Hits         5518     5519    +1     
  Misses       2518     2518           
  Partials       25       25           
Files with missing lines Coverage Δ
packages/client/src/clients/feed/feed.ts 81.81% <100.00%> (+0.03%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants