Skip to content

chore: clean up guide toolbar v1 code#960

Merged
thomaswhyyou merged 4 commits into
mainfrom
thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2
Apr 24, 2026
Merged

chore: clean up guide toolbar v1 code#960
thomaswhyyou merged 4 commits into
mainfrom
thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2

Conversation

@thomaswhyyou
Copy link
Copy Markdown
Contributor

@thomaswhyyou thomaswhyyou commented Apr 13, 2026

Description

Removes the guide toolbar "v1" from KnockGuideToolbar, and associated downstream code in the guide client.

Also removes the "guide.live_preview_updated" socket event and its handlers, now that the "Live preview" feature is deprecated and being removed (see https://github.com/knocklabs/switchboard/pull/6137).

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Apr 24, 2026 6:50pm
javascript-nextjs-example Ready Ready Preview, Comment Apr 24, 2026 6:50pm
javascript-slack-connect-example Ready Ready Preview, Comment Apr 24, 2026 6:50pm
javascript-slack-kit-example Ready Ready Preview, Comment Apr 24, 2026 6:50pm

Request Review

@linear
Copy link
Copy Markdown

linear Bot commented Apr 13, 2026

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 13, 2026

🦋 Changeset detected

Latest commit: 7da6b52

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@knocklabs/react-core Patch
@knocklabs/client Patch
@knocklabs/react Patch
@knocklabs/expo Patch
@knocklabs/react-native Patch
client-example Patch
guide-example Patch
ms-teams-connect-example Patch
nextjs-app-dir-example Patch
nextjs-example Patch
slack-connect-example Patch
slack-kit-example Patch
@knocklabs/expo-example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor Author

thomaswhyyou commented Apr 13, 2026

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2 branch from 6a5d677 to 09c169d Compare April 13, 2026 20:29
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-12634-toolbar-rename-stageresults-keys-to-bykey-and-bytype branch from f99231d to 34f8bb6 Compare April 13, 2026 20:29
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2 branch from 09c169d to 9b4db11 Compare April 13, 2026 20:43
@thomaswhyyou thomaswhyyou changed the title clean up guide toolbar v1 code chore: clean up guide toolbar v1 code Apr 13, 2026
Base automatically changed from thomas-kno-12634-toolbar-rename-stageresults-keys-to-bykey-and-bytype to main April 14, 2026 16:19
@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2 branch from 9b4db11 to dce6024 Compare April 21, 2026 18:01

export const checkActivatable = (
guide: KnockGuide,
guide: Pick<KnockGuide, "activation_url_rules" | "activation_url_patterns">,
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small unrelated thing: loosen the type requirement to allow potentially re-using it in dashboard.

@thomaswhyyou
Copy link
Copy Markdown
Contributor Author

@cursor review

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1e1ac36. Configure here.

@thomaswhyyou thomaswhyyou force-pushed the thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2 branch from 28721a7 to 7da6b52 Compare April 24, 2026 18:47
@thomaswhyyou thomaswhyyou merged commit ffa7bd2 into main Apr 24, 2026
12 of 13 checks passed
@thomaswhyyou thomaswhyyou deleted the thomas-kno-11523-sdk-clean-up-trackdebugparams-once-we-ship-toolbar-v2 branch April 24, 2026 19:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.54%. Comparing base (0862e8e) to head (7da6b52).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...src/modules/guide/providers/KnockGuideProvider.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #960      +/-   ##
==========================================
- Coverage   63.82%   63.54%   -0.28%     
==========================================
  Files         210      208       -2     
  Lines       10133     9921     -212     
  Branches     1304     1278      -26     
==========================================
- Hits         6467     6304     -163     
+ Misses       3641     3592      -49     
  Partials       25       25              
Files with missing lines Coverage Δ
packages/client/src/clients/guide/client.ts 94.30% <100.00%> (+3.56%) ⬆️
packages/client/src/clients/guide/index.ts 100.00% <100.00%> (ø)
packages/client/src/clients/guide/types.ts 100.00% <ø> (ø)
...e/src/modules/guide/context/KnockGuideProvider.tsx 96.36% <ø> (-0.19%) ⬇️
...eact/src/modules/guide/components/Toolbar/index.ts 100.00% <ø> (ø)
...ckages/react/src/modules/guide/components/index.ts 100.00% <100.00%> (ø)
packages/react/src/modules/guide/index.ts 100.00% <ø> (ø)
...src/modules/guide/providers/KnockGuideProvider.tsx 18.18% <50.00%> (+1.51%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants