Skip to content

URGENT fix(KNO-12828): upgrade axios to 1.15.1#975

Merged
andy-knock merged 2 commits into
mainfrom
andy-kno-12828-javascript-upgrade-axios-to-1151
Apr 22, 2026
Merged

URGENT fix(KNO-12828): upgrade axios to 1.15.1#975
andy-knock merged 2 commits into
mainfrom
andy-kno-12828-javascript-upgrade-axios-to-1151

Conversation

@andy-knock
Copy link
Copy Markdown
Contributor

@andy-knock andy-knock commented Apr 21, 2026 •
edited
Loading

@linear
Copy link
Copy Markdown

linear Bot commented Apr 21, 2026

KNO-12830 [Dashboard] Upgrade axios to 1.15.1

KNO-12828 [Javascript] Upgrade axios to 1.15.1

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 21, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
javascript-ms-teams-connect-example Ready Ready Preview, Comment Apr 22, 2026 2:47pm
javascript-nextjs-example Ready Ready Preview, Comment Apr 22, 2026 2:47pm
javascript-slack-connect-example Ready Ready Preview, Comment Apr 22, 2026 2:47pm
javascript-slack-kit-example Ready Ready Preview, Comment Apr 22, 2026 2:47pm

Request Review

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 21, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3f0a422

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@andy-knock Graphite App
Copy link
Copy Markdown
Contributor Author

andy-knock commented Apr 21, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@andy-knock andy-knock marked this pull request as ready for review April 21, 2026 21:34
@andy-knock andy-knock requested a review from a team as a code owner April 21, 2026 21:34
@andy-knock andy-knock requested review from meryldakin and thomaswhyyou and removed request for a team April 21, 2026 21:34
@andy-knock andy-knock closed this Apr 21, 2026
@andy-knock andy-knock changed the title URGENT fix(KNO-12830): upgrade axios to 1.15.1 URGENT fix(KNO-12828): upgrade axios to 1.15.1 Apr 21, 2026
@andy-knock andy-knock reopened this Apr 21, 2026
aburgel
aburgel reviewed Apr 22, 2026
View reviewed changes
Comment thread packages/client/package.json Outdated
cursor[bot]
cursor Bot reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 19479b6. Configure here.

@andy-knock andy-knock force-pushed the andy-kno-12828-javascript-upgrade-axios-to-1151 branch from ccd92dd to 1f204b6 Compare April 22, 2026 14:41
@andy-knock andy-knock force-pushed the andy-kno-12828-javascript-upgrade-axios-to-1151 branch from 1f204b6 to a4f46aa Compare April 22, 2026 14:42
@andy-knock andy-knock force-pushed the andy-kno-12828-javascript-upgrade-axios-to-1151 branch from a4f46aa to 3f0a422 Compare April 22, 2026 14:45
@knocklabs knocklabs deleted a comment from cursor Bot Apr 22, 2026
@andy-knock andy-knock merged commit 0862e8e into main Apr 22, 2026
13 checks passed
@andy-knock andy-knock deleted the andy-kno-12828-javascript-upgrade-axios-to-1151 branch April 22, 2026 15:23
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.82%. Comparing base (0d7e893) to head (3f0a422).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files         210      210           
  Lines       10133    10133           
  Branches     1304     1304           
=======================================
  Hits         6467     6467           
  Misses       3641     3641           
  Partials       25       25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@thomaswhyyou thomaswhyyou thomaswhyyou approved these changes

@meryldakin meryldakin Awaiting requested review from meryldakin meryldakin is a code owner automatically assigned from knocklabs/product

+1 more reviewer

@aburgel aburgel aburgel left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andy-knock @aburgel @thomaswhyyou