Merge pull request #234 from Auge19/add_knip

Add knip linter and fix all unused dependencies and exports

Author: phillipc

.github/workflows/dependency-cycle.yml

@@ -0,0 +1,32 @@
+name: Checking package dependencies with knip and lerna
+
+on:
+  # Runs for every pull-requests created
+  pull_request:
+  push:
+    branches: [main]
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
+
+jobs:
+  knip:
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v6
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v6
+        with:
+          node-version: 24
+          cache: 'npm'
+
+      - name: Build TKO
+        run: make
+
+      - name: Check for dependency cycles and faulty imports/exports with knip
+        run: make knip
+
+      - name: Check lerna packages
+        run: make lerna-check

Makefile

@@ -52,6 +52,9 @@ format-fix:
 tsc:
 	$(NPX) tsc
 
+knip:
+	$(NPX) knip --no-config-hints
+
 eslint:
 	$(NPX) eslint .
 
@@ -67,6 +70,9 @@ dts:
 docker-build:
 	$(DOCKER) build . --tag tko
 
+lerna-check:
+	$(LERNA) exec --stream -- true
+
 # Run the `repackage` target in every directory.  Essentially
 # homogenizes the `package.json`.
 repackage: tools/repackage.mjs

builds/knockout/package.json

@@ -61,8 +61,7 @@
     "@tko/provider.multi": "^4.0.0",
     "@tko/provider.virtual": "^4.0.0",
     "@tko/utils.component": "^4.0.0",
-    "@tko/utils.functionrewrite": "^4.0.0",
-    "tslib": "^2.2.0"
+    "@tko/utils.functionrewrite": "^4.0.0"
   },
   "exports": {
     ".": {

builds/reference/package.json

@@ -30,8 +30,7 @@
     "@tko/provider.native": "^4.0.0",
     "@tko/provider.virtual": "^4.0.0",
     "@tko/utils.component": "^4.0.0",
-    "@tko/utils.jsx": "^4.0.0",
-    "tslib": "^2.2.0"
+    "@tko/utils.jsx": "^4.0.0"
   },
   "files": [
     "dist/",

eslint.config.js

@@ -1,30 +1,29 @@
-import globals from "globals";
-import pluginJs from "@eslint/js";
-import tseslint from "typescript-eslint";
+const pluginJs = require('@eslint/js')
+const tseslint = require('typescript-eslint')
 
 
 /** @type {import('eslint').Linter.Config[]} */
-export default [
+module.exports = [
   pluginJs.configs.recommended,
   ...tseslint.configs.recommended,
-  { ignores: ['**/*.{js,mjs,cjs}', 'builds/**/*'] },
+  { ignores: ['**/*.{js,mjs,cjs}', 'builds/**/*', '**/*.d.ts'] },
   {
     rules: {
-      "no-empty": "off",
-      "prefer-rest-params" : "off",
-      "prefer-spread": "off",
-      "prefer-const": "off",
-      "no-useless-escape": "off",
-      "no-useless-assignment": "off",
+      'no-empty': 'off',
+      'prefer-rest-params': 'off',
+      'prefer-spread': 'off',
+      'prefer-const': 'off',
+      'no-useless-escape': 'off',
+      'no-useless-assignment': 'off',
 //    "no-var": "off",
-      "no-array-constructor": "off",
-      "no-misleading-character-class": "off",
-      "@typescript-eslint/no-this-alias": "off",
-      "@typescript-eslint/no-array-constructor": "off",
-      "@typescript-eslint/no-explicit-any": "off",
-      "@typescript-eslint/no-require-imports": "off",
-      "@typescript-eslint/no-unused-vars" : "off",
-      "@typescript-eslint/no-unsafe-function-type": "off"
+      'no-array-constructor': 'off',
+      'no-misleading-character-class': 'off',
+      '@typescript-eslint/no-this-alias': 'off',
+      '@typescript-eslint/no-array-constructor': 'off',
+      '@typescript-eslint/no-explicit-any': 'off',
+      '@typescript-eslint/no-require-imports': 'off',
+      '@typescript-eslint/no-unused-vars': 'off',
+      '@typescript-eslint/no-unsafe-function-type': 'off'
     }
   }
-];
+]

knip.json

@@ -0,0 +1,21 @@
+{
+  "$schema": "https://unpkg.com/knip@5/schema.json",
+  "ignoreExportsUsedInFile": {
+    "interface": true,
+    "type": true
+  },
+  "tags": [
+    "-lintignore",
+    "-internal"
+  ],
+  "ignoreBinaries": ["make"],
+  "ignoreDependencies": ["@types/mocha", "chai", "electron", "esbuild", "fs-extra", "karma[.]*", "mocha", "nyc", "prettier", "sinon", "lerna"],
+  "workspaces": {
+    "packages/*": {
+      "entry": "src/index.ts",
+      "project": "src/**/*.ts",
+      "ignore": ["/helpers/**"]
+    }
+  },
+  "ignoreWorkspaces": ["builds/**", "docs/**", "tko.io/**", "tools/**"]
+}