Merge pull request #230 from Auge19/workflow_firefox

test) add a firefox runner

Author: phillipc

.github/workflows/test-headless.yml

@@ -13,8 +13,8 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [22.x]
-        jquery: ['off','on']
+        node-version: [24]
+        run: ['test-headless','test-headless-jquery', 'test-headless-ff']
 
     steps:
       - name: Checkout code
@@ -32,10 +32,5 @@ jobs:
       - name: Run Build
         run: make
 
-      - name: Run Test-Headless (without JQuery)
-        if: "contains(${{ matrix.jquery }}, 'off')"
-        run: make test-headless
-
-      - name: Run Test-Headless (with JQuery)
-        if: "contains(${{matrix.jquery }}, 'on')"
-        run: make test-headless-jquery
+      - name: Run ${{ matrix.run }}
+        run: make ${{ matrix.run }}

Makefile

@@ -29,6 +29,9 @@ test-headless:
 test-headless-jquery:
 	$(LERNA) exec --stream -- $(MAKE) test-headless-jquery
 
+test-headless-ff:
+	$(LERNA) exec --stream -- $(MAKE) test-headless-ff
+
 ci:
 	$(LERNA) exec --stream --concurrency=1 -- $(MAKE) test-ci
 

README.md

@@ -152,6 +152,16 @@ wget https://dl.google.com/linux/direct/google-chrome-stable_current_amd64.deb
 sudo apt -y install ./google-chrome-stable_current_amd64.deb
 ```
 
+Install Firefox for "make test-headless-ff":
+```bash
+sudo add-apt-repository ppa:mozillateam/ppa
+sudo apt install xvfb firefox-esr
+sudo ln -s /usr/lib/firefox-esr/firefox.sh /usr/bin/firefox
+
+or 
+export FIREFOX_BIN=/usr/bin/firefox-esr
+```
+
 ## Next steps
 
 There's an [issue for that](https://github.com/knockout/tko/issues/1).