Skip to content

Commit c827149

Browse files
Brian M Huntclaude
authored andcommitted
Fix broken module paths, remove helpers from published packages
The module field in 22 package.json files pointed to non-existent files (e.g. dist/bind.js). esbuild outputs dist/index.js. Bundlers using the module field would get resolution errors. Also remove helpers/ from files and exports — test helpers shouldn't ship to npm consumers. Based on phillipc's work in PR #295, applied cleanly to current main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent c917c2a commit c827149

27 files changed

Lines changed: 76 additions & 130 deletions

File tree

builds/knockout/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@
2626
]
2727
},
2828
"files": [
29-
"dist/",
30-
"helpers/"
29+
"dist/"
3130
],
3231
"licenses": [
3332
{
@@ -57,7 +56,6 @@
5756
".": {
5857
"require": "./dist/index.cjs",
5958
"import": "./dist/index.mjs"
60-
},
61-
"./helpers/*": "./helpers/*"
59+
}
6260
}
6361
}

builds/reference/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
"tslib": "^2.2.0"
3030
},
3131
"files": [
32-
"dist/",
33-
"helpers/"
32+
"dist/"
3433
],
3534
"homepage": "https://tko.io",
3635
"licenses": [
@@ -43,8 +42,7 @@
4342
".": {
4443
"require": "./dist/index.cjs",
4544
"import": "./dist/index.mjs"
46-
},
47-
"./helpers/*": "./helpers/*"
45+
}
4846
},
4947
"bugs": {
5048
"url": "https://github.com/knockout/tko/issues"

packages/bind/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"version": "4.0.0",
33
"name": "@tko/bind",
44
"description": "TKO DOM-Observable Binding",
5-
"module": "dist/bind.js",
5+
"module": "dist/index.js",
66
"dependencies": {
77
"@tko/computed": "^4.0.0",
88
"@tko/lifecycle": "^4.0.0",
@@ -15,8 +15,7 @@
1515
"@tko/binding.foreach": "^4.0.0"
1616
},
1717
"files": [
18-
"dist/",
19-
"helpers/"
18+
"dist/"
2019
],
2120
"repository": {
2221
"type": "git",
@@ -39,7 +38,6 @@
3938
".": {
4039
"require": "./dist/index.cjs",
4140
"import": "./dist/index.js"
42-
},
43-
"./helpers/*": "./helpers/*"
41+
}
4442
}
4543
}

packages/binding.component/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"version": "4.0.0",
33
"name": "@tko/binding.component",
44
"description": "component: binding for web components",
5-
"module": "dist/binding.component.js",
5+
"module": "dist/index.js",
66
"license": "MIT",
77
"dependencies": {
88
"@tko/bind": "^4.0.0",
@@ -16,8 +16,7 @@
1616
"tslib": "^2.2.0"
1717
},
1818
"files": [
19-
"dist/",
20-
"helpers/"
19+
"dist/"
2120
],
2221
"homepage": "https://tko.io",
2322
"licenses": [
@@ -30,8 +29,7 @@
3029
".": {
3130
"require": "./dist/index.cjs",
3231
"import": "./dist/index.js"
33-
},
34-
"./helpers/*": "./helpers/*"
32+
}
3533
},
3634
"bugs": {
3735
"url": "https://github.com/knockout/tko/issues"

packages/binding.core/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22
"version": "4.0.0",
33
"name": "@tko/binding.core",
44
"description": "TKO Core bindings",
5-
"module": "dist/binding.core.js",
5+
"module": "dist/index.js",
66
"files": [
7-
"dist/",
8-
"helpers/"
7+
"dist/"
98
],
109
"repository": {
1110
"type": "git",
@@ -39,7 +38,6 @@
3938
".": {
4039
"require": "./dist/index.cjs",
4140
"import": "./dist/index.js"
42-
},
43-
"./helpers/*": "./helpers/*"
41+
}
4442
}
4543
}

packages/binding.foreach/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22
"version": "4.0.0",
33
"name": "@tko/binding.foreach",
44
"description": "Knockout Foreach Binding",
5-
"module": "dist/binding.foreach.js",
5+
"module": "dist/index.js",
66
"files": [
7-
"dist/",
8-
"helpers/"
7+
"dist/"
98
],
109
"repository": {
1110
"type": "git",
@@ -39,7 +38,6 @@
3938
".": {
4039
"require": "./dist/index.cjs",
4140
"import": "./dist/index.js"
42-
},
43-
"./helpers/*": "./helpers/*"
41+
}
4442
}
4543
}

packages/binding.if/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22
"version": "4.0.0",
33
"name": "@tko/binding.if",
44
"description": "TKO conditional (if/ifnot/unless/with/else) bindings",
5-
"module": "dist/binding.if.js",
5+
"module": "dist/index.js",
66
"files": [
7-
"dist/",
8-
"helpers/"
7+
"dist/"
98
],
109
"repository": {
1110
"type": "git",
@@ -39,7 +38,6 @@
3938
".": {
4039
"require": "./dist/index.cjs",
4140
"import": "./dist/index.js"
42-
},
43-
"./helpers/*": "./helpers/*"
41+
}
4442
}
4543
}

packages/binding.template/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22
"version": "4.0.0",
33
"name": "@tko/binding.template",
44
"description": "TKO Template bindings",
5-
"module": "dist/binding.template.js",
5+
"module": "dist/index.js",
66
"files": [
7-
"dist/",
8-
"helpers/"
7+
"dist/"
98
],
109
"repository": {
1110
"type": "git",
@@ -42,7 +41,6 @@
4241
".": {
4342
"require": "./dist/index.cjs",
4443
"import": "./dist/index.js"
45-
},
46-
"./helpers/*": "./helpers/*"
44+
}
4745
}
4846
}

packages/builder/package.json

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,13 @@
2828
}
2929
],
3030
"files": [
31-
"dist/",
32-
"helpers/"
31+
"dist/"
3332
],
3433
"exports": {
3534
".": {
3635
"require": "./dist/index.cjs",
3736
"import": "./dist/index.js"
38-
},
39-
"./helpers/*": "./helpers/*"
37+
}
4038
},
4139
"bugs": {
4240
"url": "https://github.com/knockout/tko/issues"

packages/computed/package.json

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,9 @@
22
"version": "4.0.0",
33
"name": "@tko/computed",
44
"description": "TKO Computed Observables",
5-
"module": "dist/computed.js",
5+
"module": "dist/index.js",
66
"files": [
7-
"dist/",
8-
"helpers/"
7+
"dist/"
98
],
109
"dependencies": {
1110
"@tko/observable": "^4.0.0",
@@ -36,7 +35,6 @@
3635
".": {
3736
"require": "./dist/index.cjs",
3837
"import": "./dist/index.js"
39-
},
40-
"./helpers/*": "./helpers/*"
38+
}
4139
}
4240
}

0 commit comments

Comments
 (0)