Replace !isRealBrowser() with isHappyDom() across test guards

`if (!isRealBrowser()) return ctx.skip('happy-dom: reason')` was a
double-negative detour — the check says "not a real browser" but the
skip reason always starts with "happy-dom:". Say what we mean directly.

All 24 guards now read:

  it('name', function (ctx: any) {
    if (isHappyDom()) return ctx.skip('happy-dom: reason')
    // body
  })

Also drops `isRealBrowser` and `isNode` from test-env.ts (neither had a
real consumer — `isNode` was scaffolding for the deferred `cli-bun`
project, and `isRealBrowser` was the double-negated wrapper of
`isHappyDom`). When we bring back a node-env project we can add them
back alongside the package.json runtime declaration scheme.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: 2 people

builds/knockout/helpers/vitest-setup.js

@@ -1,20 +1,18 @@
 import * as chai from 'chai'
 import sinon from 'sinon'
-import { isHappyDom, isRealBrowser, isNode } from '../../../packages/utils/helpers/test-env.ts'
+import { isHappyDom } from '../../../packages/utils/helpers/test-env.ts'
 
 // Set globals that builds/knockout specs and mocha-test-helpers.js expect
 globalThis.chai = chai
 globalThis.expect = chai.expect
 globalThis.sinon = sinon
 
-// Test environment detectors — used inside test bodies like:
+// Test environment detector — used inside test bodies like:
 //   it('name', function (ctx) {
-//     if (!isRealBrowser()) return ctx.skip('happy-dom: reason')
+//     if (isHappyDom()) return ctx.skip('happy-dom: reason')
 //     // ...
 //   })
 globalThis.isHappyDom = isHappyDom
-globalThis.isRealBrowser = isRealBrowser
-globalThis.isNode = isNode
 
 // Load the knockout build (sets globalThis.ko)
 import '../dist/browser.min.js'

builds/knockout/spec/components/defaultLoaderBehaviors.js

@@ -284,7 +284,7 @@ describe('Components: Default loader', function () {
       })
 
       it('Can be configured as the ID of a <textarea> element', function (ctx) {
-        if (!isRealBrowser()) return ctx.skip('happy-dom: <textarea> content parsing differs')
+        if (isHappyDom()) return ctx.skip('happy-dom: <textarea> content parsing differs')
         // Special case: the textarea's value should be interpreted as a markup string
         return testTemplateFromElement('<textarea id="my-textarea-elem">{0}</textarea>', 'my-textarea-elem')
       })
@@ -308,7 +308,7 @@ describe('Components: Default loader', function () {
       })
 
       it('Can be configured as a <textarea> element instance', function (ctx) {
-        if (!isRealBrowser()) return ctx.skip('happy-dom: <textarea> content parsing differs')
+        if (isHappyDom()) return ctx.skip('happy-dom: <textarea> content parsing differs')
         // Special case: the textarea's value should be interpreted as a markup string
         return testTemplateFromElement('<textarea>{0}</textarea>', /* elementId */ null)
       })

builds/knockout/spec/defaultBindings/attrBehaviors.js

@@ -10,7 +10,7 @@ describe('Binding: Attr', function () {
   })
 
   it('Should be able to set namespaced attribute values', function (ctx) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: Element.lookupNamespaceURI not implemented')
+    if (isHappyDom()) return ctx.skip('happy-dom: Element.lookupNamespaceURI not implemented')
     var model = { myValue: 'first value' }
     testNode.innerHTML = [
       '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">',

builds/knockout/spec/defaultBindings/optionsBehaviors.js

@@ -128,7 +128,7 @@ describe('Binding: Options', function () {
   })
 
   it('Should select caption by default and retain selection when adding multiple items', function (ctx) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: <select> auto-selection semantics diverge')
+    if (isHappyDom()) return ctx.skip('happy-dom: <select> auto-selection semantics diverge')
     // This test failed in IE<=8 without changes made in #1208
     testNode.innerHTML = '<select data-bind="options: filterValues, optionsCaption: \'foo\'">'
     var viewModel = {
@@ -147,7 +147,7 @@ describe('Binding: Options', function () {
   })
 
   it('Should trigger a change event when the options selection is populated or changed by modifying the options data (single select)', function (ctx) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: selectedIndex does not follow reordered <option>')
+    if (isHappyDom()) return ctx.skip('happy-dom: selectedIndex does not follow reordered <option>')
     var observable = new ko.observableArray(['A', 'B', 'C']),
       changeHandlerFireCount = 0
     testNode.innerHTML = "<select data-bind='options:myValues'></select>"
@@ -255,7 +255,7 @@ describe('Binding: Options', function () {
   })
 
   it('Should allow the caption to be given by an observable, and update it when the model value changes (without affecting selection)', function (ctx) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: element.options[selectedIndex] can be undefined')
+    if (isHappyDom()) return ctx.skip('happy-dom: element.options[selectedIndex] can be undefined')
     var myCaption = ko.observable('Initial caption')
     testNode.innerHTML = '<select data-bind=\'options:["A", "B"], optionsCaption: myCaption\'></select>'
     ko.applyBindings({ myCaption: myCaption }, testNode)

builds/knockout/spec/defaultBindings/valueBehaviors.js

@@ -407,7 +407,7 @@ describe('Binding: Value', function () {
     })
 
     it('When size > 1, should unselect all options when value is undefined, null, or \"\"', function (ctx) {
-      if (!isRealBrowser()) return ctx.skip('happy-dom: size>1 <select> does not honor selectedIndex = -1')
+      if (isHappyDom()) return ctx.skip('happy-dom: size>1 <select> does not honor selectedIndex = -1')
       var observable = new ko.observable('B')
       testNode.innerHTML = '<select size=\'2\' data-bind=\'options:["A", "B"], value:myObservable\'></select>'
       ko.applyBindings({ myObservable: observable }, testNode)

builds/knockout/spec/onErrorBehaviors.js

@@ -111,7 +111,7 @@ describe('onError handler', function () {
   })
 
   it('fires on async component errors', async function (ctx) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: setTimeout errors bypass window.onerror')
+    if (isHappyDom()) return ctx.skip('happy-dom: setTimeout errors bypass window.onerror')
     var component = {
       tagName: 'test-onerror',
       template: "<div data-bind='text: name'></div>",
@@ -137,7 +137,7 @@ describe('onError handler', function () {
   })
 
   it('passes through the error instance', async function (ctx) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: setTimeout errors bypass window.onerror')
+    if (isHappyDom()) return ctx.skip('happy-dom: setTimeout errors bypass window.onerror')
     var expectedInstance
     ko.tasks.schedule(function () {
       expectedInstance = new Error('Some error')

packages/binding.component/spec/componentBindingBehaviors.ts

@@ -35,7 +35,7 @@ import {
   restoreAfter,
   useMockForTasks
 } from '../../utils/helpers/mocha-test-helpers'
-import { isRealBrowser } from '../../utils/helpers/test-env'
+import { isHappyDom } from '../../utils/helpers/test-env'
 
 describe('Components: Component binding', function () {
   let testComponentName = 'test-component',
@@ -1271,7 +1271,7 @@ describe('Components: Component binding', function () {
       }
       ViewModel.register('test-component')
 
-      if (!isRealBrowser()) return ctx.skip('happy-dom: innerText whitespace rendering differs from real browsers')
+      if (isHappyDom()) return ctx.skip('happy-dom: innerText whitespace rendering differs from real browsers')
       applyBindings(outerViewModel, testNode)
       expect((testNode.children[0] as HTMLInputElement).innerText.trim()).to.deep.equal(`beep / beep`)
     })
@@ -1408,7 +1408,7 @@ describe('Components: Component binding', function () {
       }
       ViewModel.register('test-component')
 
-      if (!isRealBrowser()) return ctx.skip('happy-dom: innerText whitespace rendering differs from real browsers')
+      if (isHappyDom()) return ctx.skip('happy-dom: innerText whitespace rendering differs from real browsers')
       applyBindings(outerViewModel, testNode)
       expect((testNode.children[0] as HTMLElement).innerText.trim()).to.deep.equal(`A. B. C.`)
       const em = testNode.children[0].children[0].children[0]
@@ -1430,7 +1430,7 @@ describe('Components: Component binding', function () {
       }
       ViewModel.register('test-component')
 
-      if (!isRealBrowser()) return ctx.skip('happy-dom: innerText whitespace rendering differs from real browsers')
+      if (isHappyDom()) return ctx.skip('happy-dom: innerText whitespace rendering differs from real browsers')
       applyBindings(outerViewModel, testNode)
       expect((testNode.children[0] as HTMLElement).innerText.trim()).to.deep.equal(`B. C. E.`)
       const em = testNode.children[0].children[0].children[0]

packages/binding.core/spec/attrBehaviors.ts

@@ -12,7 +12,7 @@ import { options } from '@tko/utils'
 import * as coreBindings from '../dist'
 
 import { prepareTestNode } from '../../utils/helpers/mocha-test-helpers'
-import { isRealBrowser } from '../../utils/helpers/test-env'
+import { isHappyDom } from '../../utils/helpers/test-env'
 
 describe('Binding: Attr', function () {
   let testNode: HTMLElement
@@ -35,7 +35,7 @@ describe('Binding: Attr', function () {
   })
 
   it('Should be able to set namespaced attribute values', function (ctx: any) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: Element.lookupNamespaceURI not implemented')
+    if (isHappyDom()) return ctx.skip('happy-dom: Element.lookupNamespaceURI not implemented')
     const model = { myValue: 'first value' }
     testNode.innerHTML = [
       '<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">',

packages/binding.core/spec/optionsBehaviors.ts

@@ -13,7 +13,7 @@ import { bindings as coreBindings } from '../dist'
 import type { ObservableArray } from '@tko/observable'
 
 import { expectContainText, nodeText, prepareTestNode } from '../../utils/helpers/mocha-test-helpers'
-import { isRealBrowser } from '../../utils/helpers/test-env'
+import { isHappyDom } from '../../utils/helpers/test-env'
 
 function expectArrayEqual(actual: Array<unknown>, expected: Array<unknown>) {
   expect(actual.length).to.equal(expected.length)
@@ -185,7 +185,7 @@ describe('Binding: Options', function () {
   })
 
   it('Should select caption by default and retain selection when adding multiple items', function (ctx: any) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: <select> auto-selection semantics diverge')
+    if (isHappyDom()) return ctx.skip('happy-dom: <select> auto-selection semantics diverge')
     testNode.innerHTML = '<select data-bind="options: filterValues, optionsCaption: \'foo\'">'
     const viewModel = { filterValues: observableArray(undefined) }
     applyBindings(viewModel, testNode)
@@ -200,7 +200,7 @@ describe('Binding: Options', function () {
   })
 
   it('Should trigger a change event when the options selection is populated or changed by modifying the options data (single select)', function (ctx: any) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: selectedIndex does not follow reordered <option>')
+    if (isHappyDom()) return ctx.skip('happy-dom: selectedIndex does not follow reordered <option>')
     let myObservable: ObservableArray<string | number> = observableArray<string | number>(['A', 'B', 'C']),
       changeHandlerFireCount = 0
     testNode.innerHTML = "<select data-bind='options:myValues'></select>"
@@ -298,7 +298,7 @@ describe('Binding: Options', function () {
   })
 
   it('Should allow the caption to be given by an observable, and update it when the model value changes (without affecting selection)', function (ctx: any) {
-    if (!isRealBrowser()) return ctx.skip('happy-dom: element.options[selectedIndex] can be undefined')
+    if (isHappyDom()) return ctx.skip('happy-dom: element.options[selectedIndex] can be undefined')
     const myCaption = observable('Initial caption')
     testNode.innerHTML = '<select data-bind=\'options:["A", "B"], optionsCaption: myCaption\'></select>'
     applyBindings({ myCaption: myCaption }, testNode)

packages/binding.core/spec/valueBehaviors.ts

@@ -16,7 +16,7 @@ import { options } from '@tko/utils'
 import { bindings as coreBindings } from '../dist'
 
 import { nodeText, prepareTestNode } from '../../utils/helpers/mocha-test-helpers'
-import { isRealBrowser } from '../../utils/helpers/test-env'
+import { isHappyDom } from '../../utils/helpers/test-env'
 
 function expectArrayEqual(actual: Array<unknown>, expected: Array<unknown>) {
   expect(actual.length).to.equal(expected.length)
@@ -439,7 +439,7 @@ describe('Binding: Value', function () {
     })
 
     it('When size > 1, should unselect all options when value is undefined, null, or ""', function (ctx: any) {
-      if (!isRealBrowser()) return ctx.skip('happy-dom: size>1 <select> does not honor selectedIndex = -1')
+      if (isHappyDom()) return ctx.skip('happy-dom: size>1 <select> does not honor selectedIndex = -1')
       const myObservable = observable('B')
       testNode.innerHTML = '<select size=\'2\' data-bind=\'options:["A", "B"], value:myObservable\'></select>'
       applyBindings({ myObservable: myObservable }, testNode)