Merge pull request #299 from knockout/revert/knip-and-module-resolution

Revert unapproved knip and moduleResolution PRs

Author: brianmhunt

.github/workflows/dependency-cycle.yml

@@ -24,8 +24,6 @@ coverage-temp
 builds/**/meta
 .nyc_output
 **/dist/*
-packages/**/types
-builds/reference/types
 !packages/tko/dist/*
 
 *-debug.log
@@ -36,4 +34,3 @@ builds/reference/types
 .vscode/settings.json
 .playwright-mcp
 .playwright-cli
-.codex

.gitignore

@@ -18,8 +18,7 @@ package.json:
 node_modules: package-lock.json
 
 all:: node_modules package-lock.json
-	$(LERNA) --concurrency $(CONCURRENCY) exec --stream -- $(MAKE) && \
-	$(MAKE) dts
+	$(LERNA) --concurrency $(CONCURRENCY) exec --stream -- $(MAKE)
 
 test:
 	$(LERNA) exec --stream -- $(MAKE) test
@@ -52,27 +51,18 @@ format-fix:
 tsc:
 	$(NPX) tsc
 
-knip:
-	$(NPX) knip --no-config-hints
-
 eslint:
 	$(NPX) eslint .
 
 eslint-fix:
 	$(NPX) eslint . --fix
 
 dts:
-	rm -rf .dts-tmp
-	$(NPX) tsc --project tsconfig.dts.json --outDir .dts-tmp
-	$(NODE) tools/sync-dts.mjs .dts-tmp packages,builds/reference
-	rm -rf .dts-tmp
+	$(NPX) tsc --build tsconfig.dts.json
 
 docker-build:
 	$(DOCKER) build . --tag tko
 
-lerna-check:
-	$(LERNA) exec --stream -- true
-
 # Run the `repackage` target in every directory.  Essentially
 # homogenizes the `package.json`.
 repackage: tools/repackage.mjs
@@ -107,7 +97,6 @@ sweep:
 	rm -rf builds/*/dist/*
 	rm -rf coverage/
 	rm -rf coverage-temp/
-	rm -rf packages/*/types/*
 
 clean: sweep
 	rm -rf node_modules/

Makefile

@@ -27,8 +27,7 @@
   },
   "files": [
     "dist/",
-    "helpers/",
-    "types/"
+    "helpers/"
   ],
   "karma": {
     "frameworks": [
@@ -61,14 +60,14 @@
     "@tko/provider.multi": "^4.0.0",
     "@tko/provider.virtual": "^4.0.0",
     "@tko/utils.component": "^4.0.0",
-    "@tko/utils.functionrewrite": "^4.0.0"
+    "@tko/utils.functionrewrite": "^4.0.0",
+    "tslib": "^2.2.0"
   },
   "exports": {
     ".": {
-      "types": "./types/index.d.ts",
       "require": "./dist/index.cjs",
       "import": "./dist/index.mjs"
     },
     "./helpers/*": "./helpers/*"
   }
-}
+}

builds/knockout/package.json

@@ -30,12 +30,12 @@
     "@tko/provider.native": "^4.0.0",
     "@tko/provider.virtual": "^4.0.0",
     "@tko/utils.component": "^4.0.0",
-    "@tko/utils.jsx": "^4.0.0"
+    "@tko/utils.jsx": "^4.0.0",
+    "tslib": "^2.2.0"
   },
   "files": [
     "dist/",
-    "helpers/",
-    "types/"
+    "helpers/"
   ],
   "homepage": "https://tko.io",
   "licenses": [
@@ -46,7 +46,6 @@
   ],
   "exports": {
     ".": {
-      "types": "./types/index.d.ts",
       "require": "./dist/index.cjs",
       "import": "./dist/index.mjs"
     },
@@ -55,4 +54,4 @@
   "bugs": {
     "url": "https://github.com/knockout/tko/issues"
   }
-}
+}

builds/reference/package.json

@@ -1,6 +1,4 @@
 /**
  * Without the following the only export is `default`
- * 
  */
-// TODO remove? that is node or amd/umd stuff?
-//module.exports = require('./index').default
+module.exports = require('./index').default

builds/reference/src/common.ts

@@ -1,29 +1,30 @@
-const pluginJs = require('@eslint/js')
-const tseslint = require('typescript-eslint')
+import globals from "globals";
+import pluginJs from "@eslint/js";
+import tseslint from "typescript-eslint";
 
 
 /** @type {import('eslint').Linter.Config[]} */
-module.exports = [
+export default [
   pluginJs.configs.recommended,
   ...tseslint.configs.recommended,
-  { ignores: ['**/*.{js,mjs,cjs}', 'builds/**/*', '**/*.d.ts'] },
+  { ignores: ['**/*.{js,mjs,cjs}', 'builds/**/*'] },
   {
     rules: {
-      'no-empty': 'off',
-      'prefer-rest-params': 'off',
-      'prefer-spread': 'off',
-      'prefer-const': 'off',
-      'no-useless-escape': 'off',
-      'no-useless-assignment': 'off',
+      "no-empty": "off",
+      "prefer-rest-params" : "off",
+      "prefer-spread": "off",
+      "prefer-const": "off",
+      "no-useless-escape": "off",
+      "no-useless-assignment": "off",
 //    "no-var": "off",
-      'no-array-constructor': 'off',
-      'no-misleading-character-class': 'off',
-      '@typescript-eslint/no-this-alias': 'off',
-      '@typescript-eslint/no-array-constructor': 'off',
-      '@typescript-eslint/no-explicit-any': 'off',
-      '@typescript-eslint/no-require-imports': 'off',
-      '@typescript-eslint/no-unused-vars': 'off',
-      '@typescript-eslint/no-unsafe-function-type': 'off'
+      "no-array-constructor": "off",
+      "no-misleading-character-class": "off",
+      "@typescript-eslint/no-this-alias": "off",
+      "@typescript-eslint/no-array-constructor": "off",
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-require-imports": "off",
+      "@typescript-eslint/no-unused-vars" : "off",
+      "@typescript-eslint/no-unsafe-function-type": "off"
     }
   }
-]
+];