Merge pull request #355 from knockout/fix/deploy-docs-node-glob

fix(deploy): use Bun.Glob, pin CI Node to 24

Author: brianmhunt

.github/workflows/deploy-docs.yml

@@ -24,6 +24,11 @@ jobs:
       - name: Setup Pages
         uses: actions/configure-pages@v6
 
+      - name: Setup Node
+        uses: actions/setup-node@v6
+        with:
+          node-version: 24.x
+
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
         with:

tko.io/package.json

@@ -5,7 +5,7 @@
   "description": "TKO documentation site",
   "scripts": {
     "postinstall": "patch-package",
-    "prebuild": "node ./scripts/generate-verified-behaviors.mjs && mkdir -p public/lib && cd ../builds/knockout && bun run build && cp dist/browser.min.js ../../tko.io/public/lib/ko.js && cd ../reference && bun run build && cp dist/browser.min.js ../../tko.io/public/lib/tko.js && cd ../../tko.io && node ./scripts/bundle-tests.mjs",
+    "prebuild": "bun ./scripts/generate-verified-behaviors.mjs && mkdir -p public/lib && cd ../builds/knockout && bun run build && cp dist/browser.min.js ../../tko.io/public/lib/ko.js && cd ../reference && bun run build && cp dist/browser.min.js ../../tko.io/public/lib/tko.js && cd ../../tko.io && bun ./scripts/bundle-tests.mjs",
     "predev": "bun run prebuild",
     "dev": "ASTRO_TELEMETRY_DISABLED=1 astro dev",
     "build": "ASTRO_TELEMETRY_DISABLED=1 astro build --force",

tko.io/scripts/bundle-tests.mjs

@@ -25,7 +25,6 @@
 import { promises as fs } from 'node:fs'
 import path from 'node:path'
 import { fileURLToPath } from 'node:url'
-import { glob } from 'node:fs/promises'
 import * as esbuild from 'esbuild'
 
 const scriptDir = path.dirname(fileURLToPath(import.meta.url))
@@ -55,16 +54,19 @@ const distToSrcPlugin = {
   }
 }
 
+// Script runs under Bun (see `prebuild` in tko.io/package.json).
+// `Bun.Glob` is portable to both Bun and the dev `bun --watch`
+// path, so no Node 22+ dependency.
 async function collectSpecs(patterns) {
-  const specs = []
+  const specs = new Set()
   for (const pattern of patterns) {
-    for await (const match of glob(pattern, { cwd: repoRoot })) {
+    const g = new Bun.Glob(pattern)
+    for await (const match of g.scan({ cwd: repoRoot })) {
       if (EXCLUDE.test(match)) continue
-      specs.push(path.join(repoRoot, match))
+      specs.add(path.join(repoRoot, match))
     }
   }
-  specs.sort()
-  return specs
+  return [...specs].sort()
 }
 
 function specSlug(absPath) {