Merge pull request #389 from knockout/claude/inspiring-fermat-xaKte

brianmhunt · web-flow · commit f77d244e3c14 · 2026-05-27T18:21:32.000-02:30
chore: remove unused Node setup step and dead ForEachBinding.ForEach getter
diff --git a/.github/workflows/deploy-docs.yml b/.github/workflows/deploy-docs.yml
@@ -24,11 +24,6 @@ jobs:
       - name: Setup Pages
         uses: actions/configure-pages@v6
 
-      - name: Setup Node
-        uses: actions/setup-node@v6
-        with:
-          node-version: 24.x
-
       - name: Setup Bun
         uses: oven-sh/setup-bun@v2
         with:
diff --git a/packages/binding.foreach/src/foreach.ts b/packages/binding.foreach/src/foreach.ts
@@ -570,10 +570,6 @@ export class ForEachBinding extends AsyncBindingHandler {
     return true
   }
 
-  /* TODO: Remove; for legacy/testing */
-  static get ForEach() {
-    return this
-  }
   static get PENDING_DELETE_INDEX_SYM() {
     return PENDING_DELETE_INDEX_SYM
   }

Original file line number	Diff line number	Diff line change
`@@ -570,10 +570,6 @@ export class ForEachBinding extends AsyncBindingHandler {`
`570`	`570`	`return true`
`571`	`571`	`}`
`572`	`572`
`573`		`- /* TODO: Remove; for legacy/testing */`
`574`		`- static get ForEach() {`
`575`		`- return this`
`576`		`- }`
`577`	`573`	`static get PENDING_DELETE_INDEX_SYM() {`
`578`	`574`	`return PENDING_DELETE_INDEX_SYM`
`579`	`575`	`}`