Skip to content

fix: correct propertyChangeFired typo#294

Merged
phillipc merged 2 commits intomainfrom
pc/typo_at_value_ts
Apr 12, 2026
Merged

fix: correct propertyChangeFired typo#294
phillipc merged 2 commits intomainfrom
pc/typo_at_value_ts

Conversation

@phillipc
Copy link
Copy Markdown
Member

@phillipc phillipc commented Apr 10, 2026

This has always been there, and with the TypeScript port, it was also made into a property. Never set true and not detected because a IE10 to properly 11 case.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue with the IE autocomplete workaround where the blur event handler was referencing incorrect internal state, ensuring proper behavior during autocomplete interactions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 991936a7-2aba-4031-9a06-9a073df6360f

📥 Commits

Reviewing files that changed from the base of the PR and between 0068527 and 9ab54c1.

📒 Files selected for processing (1)
  • packages/binding.core/src/value.ts

📝 Walkthrough

Walkthrough

Removed an unused propertyChangeFired class member from the value binding class and updated the blur event handler to reference the correct existing propertyChangedFired boolean variable, eliminating redundant state tracking.

Changes

Cohort / File(s) Summary
IE AutoComplete Workaround Cleanup
packages/binding.core/src/value.ts
Deleted obsolete propertyChangeFired member and corrected blur event handler reference to use propertyChangedFired instead, consolidating duplicate state tracking.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A member unused, now removed with care,
The blur event handler fixed from its snare,
One boolean reigns where two used to play,
Cleaner bindings hop forward today! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: fixing a typo where 'propertyChangeFired' is corrected to 'propertyChangedFired' in the value binding class.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pc/typo_at_value_ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@phillipc phillipc requested a review from brianmhunt April 10, 2026 19:04
@phillipc phillipc merged commit df6e083 into main Apr 12, 2026
8 checks passed
@phillipc phillipc deleted the pc/typo_at_value_ts branch April 12, 2026 10:21
Copy link
Copy Markdown
Member

@brianmhunt brianmhunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retro-reviewed. Legitimate bugfix — corrects propertyChangeFired typo to propertyChangedFired in value.ts IE autocomplete handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants