Skip to content

Fixing package.json module paths and remove helpers #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phillipc wants to merge 2 commits into from
Closed

Fixing package.json module paths and remove helpers #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eea85e
refactor: update package.json module paths and remove helpers
phillipc Apr 12, 2026
1aba4c8
fix: update module path in package.json for computed package
phillipc Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions builds/reference/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
},
"files": [
"dist/",
"helpers/",
"types/"
],
"homepage": "https://tko.io",
Expand All @@ -49,8 +48,7 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.mjs"
},
"./helpers/*": "./helpers/*"
}
},
"bugs": {
"url": "https://github.com/knockout/tko/issues"
Expand Down
6 changes: 2 additions & 4 deletions packages/bind/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"version": "4.0.0",
"name": "@tko/bind",
"description": "TKO DOM-Observable Binding",
"module": "dist/bind.js",
"module": "dist/index.js",
"dependencies": {
"@tko/computed": "^4.0.0",
"@tko/lifecycle": "^4.0.0",
Expand All @@ -14,7 +14,6 @@
},
"files": [
"dist/",
"helpers/",
"types/"
],
"repository": {
Expand Down Expand Up @@ -44,7 +43,6 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
}
}
6 changes: 2 additions & 4 deletions packages/binding.component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"version": "4.0.0",
"name": "@tko/binding.component",
"description": "component: binding for web components",
"module": "dist/binding.component.js",
"module": "dist/index.js",
"license": "MIT",
"dependencies": {
"@tko/bind": "^4.0.0",
Expand All @@ -15,7 +15,6 @@
},
"files": [
"dist/",
"helpers/",
"types/"
],
"karma": {
Expand All @@ -35,8 +34,7 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"bugs": {
"url": "https://github.com/knockout/tko/issues"
Expand Down
6 changes: 2 additions & 4 deletions packages/binding.core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/binding.core",
"description": "TKO Core bindings",
"module": "dist/binding.core.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"repository": {
Expand Down Expand Up @@ -45,7 +44,6 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
}
}
6 changes: 2 additions & 4 deletions packages/binding.foreach/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/binding.foreach",
"description": "Knockout Foreach Binding",
"module": "dist/binding.foreach.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
Comment on lines +5 to 9
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify whether this PR includes a changeset describing affected packages.
fd -e md . .changeset
rg -n '@tko/(binding\.foreach|filter\.punches|provider\.multi|utils\.component|binding\.component|provider\.mustache|utils\.functionrewrite|binding\.core)' .changeset

Repository: knockout/tko

Length of output: 527

🏁 Script executed:

#!/bin/bash
# List all files in .changeset directory to identify actual changeset entries
ls -lah .changeset/ | grep -v "^d" | grep -v "^total"
# Also count markdown files (excluding README)
find .changeset -maxdepth 1 -name "*.md" -type f ! -name "README.md" | wc -l
# Show any markdown files that are not README
find .changeset -maxdepth 1 -name "*.md" -type f ! -name "README.md"

Repository: knockout/tko

Length of output: 179

Add a changeset entry for this public packaging change.

This PR removes previously published/importable helpers and changes package entrypoint metadata across multiple packages. Create a .changeset/*.md file using npx changeset add to document the affected packages and bump type.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/binding.foreach/package.json` around lines 5 - 9, The package.json
was changed to alter the published entrypoints ("module": "dist/index.js" and
"files": ["dist/","types/"]) and this is a public packaging change that requires
a Changeset; run npx changeset add and create a .changeset/*.md entry
documenting the package (packages/binding.foreach) with a description of the
breaking/public change and the appropriate version bump (patch/minor/major as
applicable) so the change will be published and tracked; ensure the changeset
file names the package and the change type, and commit the new .changeset/*.md
file alongside the package.json change.

"repository": {
Expand Down Expand Up @@ -44,7 +43,6 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
}
}
6 changes: 2 additions & 4 deletions packages/binding.if/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/binding.if",
"description": "TKO conditional (if/ifnot/unless/with/else) bindings",
"module": "dist/binding.if.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"repository": {
Expand Down Expand Up @@ -44,7 +43,6 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
}
}
2 changes: 1 addition & 1 deletion packages/binding.template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"version": "4.0.0",
"name": "@tko/binding.template",
"description": "TKO Template bindings",
"module": "dist/binding.template.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
Expand Down
4 changes: 1 addition & 3 deletions packages/builder/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,14 @@
],
"files": [
"dist/",
"helpers/",
"types/"
],
"exports": {
".": {
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"karma": {
"frameworks": [
Expand Down
6 changes: 2 additions & 4 deletions packages/computed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/computed",
"description": "TKO Computed Observables",
"module": "dist/computed.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"dependencies": {
Expand Down Expand Up @@ -42,7 +41,6 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
}
}
6 changes: 2 additions & 4 deletions packages/filter.punches/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/filter.punches",
"description": "TKO filters from knockout punches",
"module": "dist/filter.punches.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"repository": {
Expand Down Expand Up @@ -42,7 +41,6 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
}
}
6 changes: 2 additions & 4 deletions packages/lifecycle/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"version": "4.0.0",
"module": "dist/lifecycle.js",
"module": "dist/index.js",
"dependencies": {
"@tko/computed": "^4.0.0",
"@tko/utils": "^4.0.0"
Expand All @@ -10,7 +10,6 @@
},
"files": [
"dist/",
"helpers/",
"types/"
],
"name": "@tko/lifecycle",
Expand Down Expand Up @@ -38,8 +37,7 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"bugs": {
"url": "https://github.com/knockout/tko/issues"
Expand Down
4 changes: 1 addition & 3 deletions packages/observable/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,10 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"files": [
"dist/",
"helpers/",
"types/"
],
"keywords": [
Expand Down
6 changes: 2 additions & 4 deletions packages/provider.attr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/provider.attr",
"description": "Link HTML attributes (e.g. ko-handler-name) to binding handlers",
"module": "dist/provider.attr.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"license": "MIT",
Expand All @@ -29,8 +28,7 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"bugs": {
"url": "https://github.com/knockout/tko/issues"
Expand Down
6 changes: 2 additions & 4 deletions packages/provider.bindingstring/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/provider.bindingstring",
"description": "Abstract Base Class for providers that parse a binding string",
"module": "dist/provider.bindingString.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"license": "MIT",
Expand All @@ -30,8 +29,7 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"bugs": {
"url": "https://github.com/knockout/tko/issues"
Expand Down
6 changes: 2 additions & 4 deletions packages/provider.component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/provider.component",
"description": "Bind custom web components e.g. <custom-binding>",
"module": "dist/provider.component.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"license": "MIT",
Expand Down Expand Up @@ -34,8 +33,7 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"bugs": {
"url": "https://github.com/knockout/tko/issues"
Expand Down
6 changes: 2 additions & 4 deletions packages/provider.databind/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/provider.databind",
"description": "Link HTML attributes based on a `data-bind` HTML attribute",
"module": "dist/provider.databind.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"license": "MIT",
Expand All @@ -30,8 +29,7 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"bugs": {
"url": "https://github.com/knockout/tko/issues"
Expand Down
6 changes: 2 additions & 4 deletions packages/provider.multi/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/provider.multi",
"description": "Combine multiple other providers into one",
"module": "dist/provider.multi.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"license": "MIT",
Expand All @@ -30,8 +29,7 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
},
"bugs": {
"url": "https://github.com/knockout/tko/issues"
Expand Down
6 changes: 2 additions & 4 deletions packages/provider.mustache/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@
"version": "4.0.0",
"name": "@tko/provider.mustache",
"description": "Interpolate text/node attributes {{ }}",
"module": "dist/provider.mustache.js",
"module": "dist/index.js",
"files": [
"dist/",
"helpers/",
"types/"
],
"repository": {
Expand Down Expand Up @@ -44,7 +43,6 @@
"types": "./types/index.d.ts",
"require": "./dist/index.cjs",
"import": "./dist/index.js"
},
"./helpers/*": "./helpers/*"
}
}
}
Loading
Loading