Remove dead TextInputLegacyFirefox class#346
Conversation
The class overrode a non-existent method (eventsIndicatingValueChange) instead of eventsIndicatingSyncValueChange, so it never had any effect. Firefox 3.x is long EOL.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 54 minutes and 42 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 participants
Summary
Removes the
TextInputLegacyFirefoxclass frompackages/binding.core/src/textInput.ts.Detected in #297
Why
The class was dead code — it overrode a method named
eventsIndicatingValueChange()which doesn't exist on the parent. The actual method iseventsIndicatingSyncValueChange(), so the override never took effect. Additionally, Firefox 3.x (the target) has been EOL for over a decade.Verification
All 46 textInput tests pass.