Skip to content

Remove dead TextInputLegacyFirefox class #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phillipc merged 1 commit into from
Apr 22, 2026
Merged

Remove dead TextInputLegacyFirefox class #346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions packages/binding.core/src/textInput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { BindingHandler } from '@tko/bind'

export const MSIE_REGEX = /MSIE ([^ ;]+)|rv:([^ )]+)/

let operaVersion, safariVersion, firefoxVersion, ieVersion
let operaVersion, safariVersion, ieVersion

/**
* TextInput binding handler for modern browsers (legacy below).
Expand Down Expand Up @@ -129,19 +129,6 @@ class TextInputLegacyOpera extends TextInput {
}
}

class TextInputLegacyFirefox extends TextInput {
eventsIndicatingValueChange(): string[] {
return [
...super.eventsIndicatingSyncValueChange(),
// Firefox <= 3.6 doesn't fire the 'input' event when text is filled in through autocomplete
'DOMAutoComplete',
// Firefox <=3.5 doesn't fire the 'input' event when text is dropped into the input.
'dragdrop', // < 3.5
'drop' // 3.5
]
}
}

const w = options.global // window / global
if (w.navigator) {
const parseVersion = matches => matches && parseFloat(matches[1])
Expand All @@ -151,7 +138,6 @@ if (w.navigator) {
// Detect various browser versions because some old versions don't fully support the 'input' event
operaVersion = w.opera && w.opera.version && parseInt(w.opera.version())
safariVersion = parseVersion(userAgent.match(/Version\/([^ ]+) Safari/))
firefoxVersion = parseVersion(userAgent.match(/Firefox\/([^ ]*)/))
const ieMatch = userAgent.match(MSIE_REGEX)
ieVersion = ieMatch && (parseFloat(ieMatch[1]) || parseFloat(ieMatch[2]))
}
Expand All @@ -164,6 +150,4 @@ export const textInput =
? TextInputLegacySafari
: operaVersion && operaVersion < 11
? TextInputLegacyOpera
: firefoxVersion && firefoxVersion < 4
? TextInputLegacyFirefox
: TextInput
: TextInput
Loading