Fix makeTemplateNode bypassing HTML sanitization#352
Fix makeTemplateNode bypassing HTML sanitization#352phillipc wants to merge 1 commit intoknockout:mainfrom
Conversation
Route <script> template content through validateHTMLInput in makeTemplateNode so templateSizeLimit, allowScriptTagsInTemplates, and sanitizeHtmlTemplate checks apply.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 36 minutes and 28 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
makeTemplateNodeinpackages/binding.foreach/src/foreach.tsassignedsourceNode.textdirectly toparentNode.innerHTMLfor<script>template elements, bypassing all three HTML sanitization controls:options.templateSizeLimitoptions.allowScriptTagsInTemplatesoptions.sanitizeHtmlTemplateDetected in Add TypeScript code review skill and updated findings plans #350
Fix
validateHTMLInputfrom@tko/utils(was previously internal tohtml.ts)<script>element's.textthroughvalidateHTMLInput()before assigning toinnerHTMLThis ensures the same size-limit, script-tag, and custom sanitizer checks apply to foreach
<script>templates as they do everywhere else viaparseHtmlFragment.Testing
All 158 existing foreach tests pass (happy-dom + chromium).