From 7c29892e7e18c4c437e68dacfb20f8b7a85c3355 Mon Sep 17 00:00:00 2001 From: Brian M Hunt Date: Wed, 22 Apr 2026 09:38:25 -0400 Subject: [PATCH 1/2] fix(tests): use this.skip() when cross-window popup is blocked MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Both cross-window specs silently `return` when `window.open` yields null (popup blocker). Mocha counts a sync function that throws nothing as a pass, so blocked-popup runs looked green while actually skipping every cross-window assertion — a silent coverage gap. Swap the bare `return` for `return this.skip('popup blocked — ...')` so the suite correctly reports these as pending (○) in the stats chip, making the blocked state visible to contributors running /tests and to CI. --- builds/knockout/spec/crossWindowBehaviors.js | 2 +- packages/bind/spec/crossWindowBehaviors.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builds/knockout/spec/crossWindowBehaviors.js b/builds/knockout/spec/crossWindowBehaviors.js index c7c56558..9e417852 100644 --- a/builds/knockout/spec/crossWindowBehaviors.js +++ b/builds/knockout/spec/crossWindowBehaviors.js @@ -5,7 +5,7 @@ describe('Cross-window support', function () { var win2 = window.open('', '_blank', 'height=150,location=no,menubar=no,toolbar=no,width=250') if (!win2) { - return + return this.skip('popup blocked — cross-window assertions cannot run') } var blankHtml = '' diff --git a/packages/bind/spec/crossWindowBehaviors.ts b/packages/bind/spec/crossWindowBehaviors.ts index e3901d4d..e13635ad 100644 --- a/packages/bind/spec/crossWindowBehaviors.ts +++ b/packages/bind/spec/crossWindowBehaviors.ts @@ -50,7 +50,7 @@ describe('Cross-window support', function () { const win2 = window.open('', '_blank', 'height=150,location=no,menubar=no,toolbar=no,width=250') if (!win2) { - return + return this.skip('popup blocked — cross-window assertions cannot run') } const previousTemplateEngine = nativeTemplateEngine.instance From 708c2875bc1698084c5426ca6c8c581f791131fb Mon Sep 17 00:00:00 2001 From: Brian M Hunt Date: Wed, 22 Apr 2026 09:44:36 -0400 Subject: [PATCH 2/2] =?UTF-8?q?fix(tests):=20drop=20skip()=20string=20arg?= =?UTF-8?q?=20=E2=80=94=20Mocha=20types=20are=200-arg?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/bind/spec/crossWindowBehaviors.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/bind/spec/crossWindowBehaviors.ts b/packages/bind/spec/crossWindowBehaviors.ts index e13635ad..100d000b 100644 --- a/packages/bind/spec/crossWindowBehaviors.ts +++ b/packages/bind/spec/crossWindowBehaviors.ts @@ -50,7 +50,9 @@ describe('Cross-window support', function () { const win2 = window.open('', '_blank', 'height=150,location=no,menubar=no,toolbar=no,width=250') if (!win2) { - return this.skip('popup blocked — cross-window assertions cannot run') + // Popup blocked — skip so mocha reports pending (○) instead + // of silently passing with zero assertions. + return this.skip() } const previousTemplateEngine = nativeTemplateEngine.instance