chore: Fix tests

Author: dbanty

Cargo.lock

@@ -111,6 +111,7 @@ impl Display for Change {
 pub struct UniqueId(String);
 
 impl UniqueId {
+    #[must_use]
     pub fn to_file_name(&self) -> String {
         format!("{self}.md")
     }
@@ -124,7 +125,7 @@ impl<T: AsRef<str>> From<T> for UniqueId {
                 .filter_map(|c| {
                     if c.is_ascii_alphanumeric() {
                         Some(c.to_ascii_lowercase())
-                    } else if c == ' ' {
+                    } else if c == ' ' || c == '_' || c == '-' {
                         Some('_')
                     } else {
                         None
@@ -145,7 +146,7 @@ impl Display for UniqueId {
 #[test]
 fn test_create_unique_id() {
     assert_eq!(
-        UniqueId::from("`[i carry your heart with me(i carry it in]`").to_string(),
+        UniqueId::from("`[i carry your_heart with-me(i carry it in]`").to_string(),
         "i_carry_your_heart_with_mei_carry_it_in"
     );
 }

src/change.rs

@@ -1,16 +1,16 @@
-use changesets::{Change, ChangeType, Versioning};
+use changesets::{Change, ChangeType, UniqueId, Versioning};
 use tempfile::tempdir;
 
 #[test]
 fn create_change() {
     let basic_programmatic = Change {
-        unique_id: String::from("basic_programmatic"),
+        unique_id: UniqueId::from("basic_programmatic"),
         versioning: Versioning::from(("my_package", ChangeType::Minor)),
         summary: String::from("### This is a summary"),
     };
 
     let multiple_packages = Change {
-        unique_id: String::from("multiple_packages"),
+        unique_id: UniqueId::from("multiple_packages"),
         versioning: Versioning::try_from_iter([
             ("my_package", ChangeType::Minor),
             ("my_other_package", ChangeType::Major),
@@ -54,7 +54,7 @@ fn load_change() {
 
     let change = Change::from_file(&change_path).unwrap();
 
-    assert_eq!(change.unique_id, "a_change");
+    assert_eq!(change.unique_id.to_string(), "a_change");
     assert_eq!(change.summary, "### This is a summary");
     assert_eq!(
         change.versioning,

tests/change.rs

@@ -37,6 +37,7 @@ fn load_changeset() {
     assert_eq!(
         first_release.changes,
         vec![PackageChange {
+            unique_id: first_change_name.into(),
             change_type: first_change_type,
             summary: first_change_summary.to_string()
         },]
@@ -47,10 +48,12 @@ fn load_changeset() {
     // Order of reading files is probably not guaranteed
     let first_variant = vec![
         PackageChange {
+            unique_id: first_change_name.into(),
             change_type: second_package_type,
             summary: first_change_summary.to_string(),
         },
         PackageChange {
+            unique_id: second_change_name.into(),
             change_type: second_change_type,
             summary: second_change_summary.to_string(),
         },