docs(validate_dataset_schema): cite experiment.py analyze_unit() instead of drifting line numbers#101
Closed
gadievron wants to merge 1 commit into
Closed
Conversation
…ead of drifting line numbers
Two comments in validate_unit() cited hardcoded experiment.py line numbers ("lines 186-196",
"line 192") that had drifted: experiment.py:186-196 is now load_application_context(), unrelated
to unit.code/files_included. The actual code/files_included handling lives in experiment.py
analyze_unit(). Replace the brittle line-number citations with the stable function-name anchor so
they cannot re-drift.
Doc/comment-only: no behavioral change, no regression test. Verified: 0 residual
"experiment.py lines N" citations remain; experiment.py analyze_unit() handles code_field
+ files_included; ruff clean (venv py3.11).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
gadievron
requested review from
ar7casper,
dgeyshis,
shahar-davidson,
sounil and
yotamleo
as code owners
May 28, 2026 23:55
Collaborator
Author
|
Closing as already resolved on current master. This fix's behavior shipped via the parser-fix-stack release (#133/#134); confirmed by independent reproduction — the original bug (reconstructed from its bug-pipeline investigation) no longer manifests on master, not merely by line-presence. Part of a full validated sweep of the open-PR corpus. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two comments in validate_unit() cited hardcoded experiment.py line numbers ("lines 186-196",
"line 192") that had drifted: experiment.py:186-196 is now load_application_context(), unrelated
to unit.code/files_included. The actual code/files_included handling lives in experiment.py
analyze_unit(). Replace the brittle line-number citations with the stable function-name anchor so
they cannot re-drift.
Doc/comment-only: no behavioral change, no regression test. Verified: 0 residual
"experiment.py lines N" citations remain; experiment.py analyze_unit() handles code_field
Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com