Add tsc to build pipe

Author: isTravis

.github/workflows/deploy.yml

@@ -75,6 +75,11 @@ jobs:
         with:
           images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
 
+      - name: Install and typecheck
+        run: |
+          npm ci
+          npm run typecheck
+
       - name: Build and push
         uses: docker/build-push-action@v6
         with:

package.json

@@ -8,6 +8,7 @@
     "dev:server": "astro dev --host 0.0.0.0 & tsx --watch src/api/server.ts & wait",
     "dev:api": "tsx --watch src/api/server.ts",
     "build": "astro build",
+    "typecheck": "tsc --noEmit",
     "preview": "astro preview",
     "start": "node ./dist/server/entry.mjs",
     "db:generate": "drizzle-kit generate",

src/api/plugins/auth.ts

@@ -92,7 +92,7 @@ async function authPlugin(app: FastifyInstance) {
 
     // All writes (POST/PATCH/PUT/DELETE) require auth, except public paths
     if (!request.accountId) {
-      const path = request.url.split("?")[0];
+      const path = request.url.split("?")[0] ?? "";
       if (publicPaths.has(path)) return;
       return reply.status(401).send({ error: "Authentication required", statusCode: 401 });
     }

src/api/routes/files.ts

@@ -168,7 +168,7 @@ export async function fileRoutes(app: FastifyInstance) {
 
     // Redirect to CDN
     const cdnUrl = `https://assets.underlay.org/files/${cleanHash.slice(0, 2)}/${cleanHash.slice(2, 4)}/${cleanHash}`;
-    return reply.redirect(301, cdnUrl);
+    return reply.redirect(cdnUrl);
   });
 
   // Upload file

src/components/CollectionExplorer.tsx

@@ -11,7 +11,7 @@ export default function CollectionExplorer() {
   const [query, setQuery] = useState("");
   const [collections, setCollections] = useState<Collection[]>([]);
   const [loading, setLoading] = useState(true);
-  const timerRef = useRef<ReturnType<typeof setTimeout>>();
+  const timerRef = useRef<ReturnType<typeof setTimeout>>(undefined);
 
   async function load(q = "") {
     const params = new URLSearchParams();

src/components/SchemaBrowser.tsx

@@ -13,7 +13,7 @@ export default function SchemaBrowser() {
   const [filterType, setFilterType] = useState<"q" | "label" | "slug">("q");
   const [schemas, setSchemas] = useState<SchemaResult[]>([]);
   const [loading, setLoading] = useState(true);
-  const timerRef = useRef<ReturnType<typeof setTimeout>>();
+  const timerRef = useRef<ReturnType<typeof setTimeout>>(undefined);
 
   async function load(q = "", type = filterType) {
     setLoading(true);

src/components/UserMenu.tsx

@@ -13,7 +13,7 @@ interface UserMenuProps {
 export default function UserMenu({ slug, orgs = [] }: UserMenuProps) {
   const [open, setOpen] = useState(false);
   const rootRef = useRef<HTMLDivElement>(null);
-  const hideTimeout = useRef<ReturnType<typeof setTimeout>>();
+  const hideTimeout = useRef<ReturnType<typeof setTimeout>>(undefined);
 
   function show() {
     clearTimeout(hideTimeout.current);

src/lib/s3.ts

@@ -13,7 +13,7 @@ import type { Readable } from "node:stream";
 // For MinIO (dev): S3_ENDPOINT=http://minio:9000
 const s3 = new S3Client({
   region: process.env.S3_REGION ?? "auto",
-  endpoint: process.env.S3_ENDPOINT,
+  ...(process.env.S3_ENDPOINT && { endpoint: process.env.S3_ENDPOINT }),
   forcePathStyle: true,
   credentials: {
     accessKeyId: process.env.S3_ACCESS_KEY ?? "",

tsconfig.json

@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
+    "ignoreDeprecations": "6.0",
     "target": "ES2022",
     "module": "ES2022",
     "moduleResolution": "bundler",