fix(modal): Fix JS closure bug in focus restoration timeout

- Fixes issue where  was null when the 50ms timeout fired, preventing focus restoration.
- Removed invalid copy-pasted  code from  that could crash the handler before restoring focus.

Author: Kunwartejpal Sidhu

web-app/js/main.js

@@ -1259,42 +1259,6 @@ document.addEventListener("DOMContentLoaded", function () {
       removeTrap = null;
     }
 
-    recentSearchesList.innerHTML = '';
-    recentSearches.slice(0, 5).forEach((search) => {
-        const item = document.createElement('div');
-        item.className = 'dropdown-recent-item';
-        item.innerHTML = `
-            <button type="button" class="dropdown-recent-text" aria-label="Search ${search}">
-                <i class="fas fa-history" style="opacity: 0.5; font-size: 0.9rem;"></i>
-                <span style="flex: 1; color: var(--text-secondary);">${search}</span>
-            </button>
-            <button type="button" class="dropdown-recent-remove" aria-label="Remove search">
-                <i class="fas fa-x"></i>
-            </button>
-        `;
-        
-        const textButton = item.querySelector('.dropdown-recent-text');
-        const removeBtn = item.querySelector('.dropdown-recent-remove');
-        
-        if (textButton) {
-            textButton.addEventListener('click', () => {
-                searchInput.value = search;
-                currentSearchQuery = search;
-                performSearch();
-                closeDropdown();
-            });
-        }
-        
-        if (removeBtn) {
-            removeBtn.addEventListener('click', (e) => {
-                e.stopPropagation();
-                recentSearches = recentSearches.filter(s => s !== search);
-                localStorage.setItem('recentSearches', JSON.stringify(recentSearches));
-                renderRecentSearches();
-            });
-        }
-    });
-    
     // Clear content
     if (modalBody) {
       modalBody.innerHTML = "";
@@ -1304,8 +1268,9 @@ document.addEventListener("DOMContentLoaded", function () {
     }
 
     if (lastFocusedElement && typeof lastFocusedElement.focus === "function") {
+      var elemToFocus = lastFocusedElement;
       setTimeout(function () {
-        lastFocusedElement.focus({ preventScroll: true });
+        elemToFocus.focus({ preventScroll: true });
       }, 50);
     }
     lastFocusedElement = null;