Skip to content

allow client v3#473

Open
garak wants to merge 1 commit into
knpuniversity:mainfrom
garak:allow-client3
Open

allow client v3#473
garak wants to merge 1 commit into
knpuniversity:mainfrom
garak:allow-client3

Conversation

@garak
Copy link
Copy Markdown
Contributor

@garak garak commented Mar 19, 2026

Fix #472

Copilot AI review requested due to automatic review settings March 19, 2026 08:30
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the bundle’s Composer requirements to declare compatibility with league/oauth2-client v3 (in addition to v2), addressing Issue #472 requesting support for the new major version.

Changes:

  • Expand the league/oauth2-client dependency constraint from ^2.0 to ^2.0|^3.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread composer.json
"symfony/routing": "^6.4|^7.3|^8.0",
"symfony/http-foundation": "^6.4|^7.3|^8.0",
"league/oauth2-client": "^2.0",
"league/oauth2-client": "^2.0|^3.0",
Copy link
Copy Markdown
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

I see we don't have v3 stable release yet, so CI indeed didn't test it on v3 yet

@garak
Copy link
Copy Markdown
Contributor Author

garak commented Mar 19, 2026

What if I change the last CI step (highest deps) to get "dev" as minimum stability?

@bocharsky-bw
Copy link
Copy Markdown
Member

I was thinking about doing it temporarily.. or maybe we're worrying about it too early? I mean, maybe we should just wait for a stable release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please add support for league/oauth2-client 3

3 participants