Currently to check if session changed koa-session does these:
- calculates crc of JSON.stringify'ed session data when it reads session from cookie/external storage
|
this.prevHash = util.hash(this.session.toJSON()); |
|
this.prevHash = util.hash(this.session.toJSON()); |
|
return crc(JSON.stringify(sess)); |
- it calculates crc of session before commiting it and then compares new sum with old one.
So if instead of crc as a hash we will use result of JSON.stringify (i.e. const hash = (sess) => JSON.stringify(sess)) we can shave of some time from request/response processing. Not much, but it will be -1 dependency. Not sure if memory consumption will increase, i think it depends on garbage collection.
Resolves #131 and #156 (no need in faster crc calculator)
Currently to check if session changed
koa-sessiondoes these:session/lib/context.js
Line 150 in 1600aab
session/lib/context.js
Line 98 in 1600aab
session/lib/util.js
Line 35 in 1600aab
So if instead of crc as a hash we will use result of JSON.stringify (i.e.
const hash = (sess) => JSON.stringify(sess)) we can shave of some time from request/response processing. Not much, but it will be -1 dependency. Not sure if memory consumption will increase, i think it depends on garbage collection.Resolves #131 and #156 (no need in faster crc calculator)