Skip to content

Commit 3833e69

Browse files
authored
possibly fix on lark plugin v2 executing workflows (#4632)
* possibly fix on lark plugin v2 executing workflows Signed-off-by: Min Min <jamsman94@gmail.com> * added some debug logs Signed-off-by: Min Min <jamsman94@gmail.com> * possible fix Signed-off-by: Min Min <jamsman94@gmail.com> * fix codehost info not getting set when executing workflow Signed-off-by: Min Min <jamsman94@gmail.com> --------- Signed-off-by: Min Min <jamsman94@gmail.com>
1 parent f73f140 commit 3833e69

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

  • pkg/microservice/aslan/core/plugin/service

pkg/microservice/aslan/core/plugin/service/lark_v2.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -455,8 +455,11 @@ func ExecuteLarkWorkitemWorkflowV2(ctx *internalhandler.Context, workspaceID, wo
455455
if err != nil {
456456
return fmt.Errorf("failed to get input configs: %w", err)
457457
}
458-
for _, inputConfig := range inputConfigs {
459-
inputConfig.Branch = stageConfig.TargetBranch
458+
// if target branch is set and branch filter is not set, set the branch for all input configs
459+
if stageConfig.TargetBranch != "" && len(stageConfig.BranchFilter) == 0 {
460+
for _, inputConfig := range inputConfigs {
461+
inputConfig.Branch = stageConfig.TargetBranch
462+
}
460463
}
461464
} else {
462465
binds, err := mongodb.NewLarkPluginReleaseWorkItemBindColl().ListReleaseBindItems(workspaceID, workItemID)

0 commit comments

Comments
 (0)