fix user can create duplicated name webhook in workflow (#4590)

Signed-off-by: Patrick Zhao <zhaoyu@koderover.com>

Author: PetrusZ

pkg/microservice/aslan/core/common/repository/mongodb/workflow_v4_general_hook.go

@@ -127,14 +127,7 @@ func (c *WorkflowV4GeneralHookColl) Get(ctx *internalhandler.Context, workflowNa
 }
 
 func (c *WorkflowV4GeneralHookColl) Exists(ctx *internalhandler.Context, workflowName, hookName string) (bool, error) {
-	if err := c.Collection.FindOne(ctx, bson.M{"workflow_name": workflowName, "name": hookName}); err != nil {
-		if err.Err() == mongo.ErrNoDocuments {
-			return false, nil
-		}
-		return false, err.Err()
-	}
-
-	return true, nil
+	return singleResultExists(c.Collection.FindOne(ctx, bson.M{"workflow_name": workflowName, "name": hookName}))
 }
 
 func (c *WorkflowV4GeneralHookColl) Update(ctx *internalhandler.Context, id string, obj *models.WorkflowV4GeneralHook) error {

pkg/microservice/aslan/core/common/repository/mongodb/workflow_v4_git_hook.go

@@ -127,13 +127,17 @@ func (c *WorkflowV4GitHookColl) Get(ctx *internalhandler.Context, workflowName,
 }
 
 func (c *WorkflowV4GitHookColl) Exists(ctx *internalhandler.Context, workflowName, hookName string) (bool, error) {
-	if err := c.Collection.FindOne(ctx, bson.M{"workflow_name": workflowName, "name": hookName}); err != nil {
-		if err.Err() == mongo.ErrNoDocuments {
-			return false, nil
-		}
-		return false, err.Err()
-	}
+	return singleResultExists(c.Collection.FindOne(ctx, bson.M{"workflow_name": workflowName, "name": hookName}))
+}
 
+func singleResultExists(result *mongo.SingleResult) (bool, error) {
+	err := result.Err()
+	if err == mongo.ErrNoDocuments {
+		return false, nil
+	}
+	if err != nil {
+		return false, err
+	}
 	return true, nil
 }
 

pkg/microservice/aslan/core/common/repository/mongodb/workflow_v4_jira_hook.go

@@ -99,14 +99,7 @@ func (c *WorkflowV4JiraHookColl) Create(ctx *internalhandler.Context, obj *model
 }
 
 func (c *WorkflowV4JiraHookColl) Exists(ctx *internalhandler.Context, workflowName, hookName string) (bool, error) {
-	if err := c.Collection.FindOne(ctx, bson.M{"workflow_name": workflowName, "name": hookName}); err != nil {
-		if err.Err() == mongo.ErrNoDocuments {
-			return false, nil
-		}
-		return false, err.Err()
-	}
-
-	return true, nil
+	return singleResultExists(c.Collection.FindOne(ctx, bson.M{"workflow_name": workflowName, "name": hookName}))
 }
 
 func (c *WorkflowV4JiraHookColl) List(ctx *internalhandler.Context, workflowName string) ([]*models.WorkflowV4JiraHook, error) {

pkg/microservice/aslan/core/common/repository/mongodb/workflow_v4_meego_hook.go

@@ -99,14 +99,7 @@ func (c *WorkflowV4MeegoHookColl) Create(ctx *internalhandler.Context, obj *mode
 }
 
 func (c *WorkflowV4MeegoHookColl) Exists(ctx *internalhandler.Context, workflowName, hookName string) (bool, error) {
-	if err := c.Collection.FindOne(ctx, bson.M{"workflow_name": workflowName, "name": hookName}); err != nil {
-		if err.Err() == mongo.ErrNoDocuments {
-			return false, nil
-		}
-		return false, err.Err()
-	}
-
-	return true, nil
+	return singleResultExists(c.Collection.FindOne(ctx, bson.M{"workflow_name": workflowName, "name": hookName}))
 }
 
 func (c *WorkflowV4MeegoHookColl) List(ctx *internalhandler.Context, workflowName string) ([]*models.WorkflowV4MeegoHook, error) {