fix:implement workflow task cancellation before deletion in DeleteWorkflowV4 function.#4617
Open
leozhang2018 wants to merge 1 commit intokoderover:mainfrom
Open
fix:implement workflow task cancellation before deletion in DeleteWorkflowV4 function.#4617leozhang2018 wants to merge 1 commit intokoderover:mainfrom
leozhang2018 wants to merge 1 commit intokoderover:mainfrom
Conversation
…kflowV4 function. Signed-off-by: leozhang2018 <leozhang2018@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it:
When a user deletes a workflow that has queued or running tasks, the system soft-deletes all associated tasks (setting is_deleted: true, is_archived: true) without sending a cancellation signal to the execution controller. This results in:
Tasks disappear from the UI immediately (all list queries filter by is_deleted: false)
The workflow controller keeps executing the task in memory — it is unaware of the is_deleted flag
Users have no way to find or cancel the "zombie" task from any UI surface
On service restart, InitQueue also skips these tasks (InCompletedTasks filters is_deleted: false), so they are never cleaned up automatically
What is changed and how it works?
Before soft-deleting workflow tasks in DeleteWorkflowV4, query WorkflowQueueColl by workflow name to retrieve all enqueued tasks, then call CancelWorkflowTask for each one. This triggers a DB status update to Cancelled and publishes a Redis cancel signal, allowing the controller to exit gracefully. Cancellation failures are logged as warnings and do not block the deletion.
Does this PR introduce a user-facing change?
This change is