URL-encode spaces as %20 in picon HTTP request URLs

[mapi68]

Summary

Fix picon HTTP requests failing with 400 Bad Request when channel names contain spaces.

Closes #496

Problem

When fetching picons from the web interface, the addon constructs HTTP URLs using the raw picon path without URL-encoding spaces. Web servers reject these malformed URLs with a 400 Bad Request error, leaving all channels with spaces in their name without an icon.

This affects both code paths:

• Channel::CreateIconPath() — used when Use OpenWebIf picon path is disabled
• Channels::LoadChannelsExtraData() — used when Use OpenWebIf picon path is enabled

Fix

URL-encode spaces as %20 before constructing the picon URL in both code paths.

src/enigma2/data/Channel.cpp

  if (m_settings->UseOnlinePicons())
-   iconPath = StringUtils::Format("%spicon/%s.png", m_settings->GetConnectionURL().c_str(), iconPath.c_str());
+  {
+    std::string encodedPath = iconPath;
+    StringUtils::Replace(encodedPath, " ", "%20");
+    iconPath = StringUtils::Format("%spicon/%s.png", m_settings->GetConnectionURL().c_str(), encodedPath.c_str());
+  }
  else
    iconPath = m_settings->GetIconPath().c_str() + iconPath + ".png";

src/enigma2/Channels.cpp

  std::string connectionURL = m_settings->GetConnectionURL();
  connectionURL = connectionURL.substr(0, connectionURL.size() - 1);
- channel->SetIconPath(StringUtils::Format("%s%s", connectionURL.c_str(), jsonChannel["picon"].get<std::string>().c_str()));
+ std::string piconPath = jsonChannel["picon"].get<std::string>();
+ StringUtils::Replace(piconPath, " ", "%20");
+ channel->SetIconPath(StringUtils::Format("%s%s", connectionURL.c_str(), piconPath.c_str()));

[phunkyfish]

This is great, thanks for the contribution. If you like it released, please add a commit with the micro version number incremented in addon.xml.in and add a changelog entry.