Apply plugins when used as superagent.method(...args, callback)#6
Open
shesek wants to merge 1 commit into
Open
Apply plugins when used as superagent.method(...args, callback)#6shesek wants to merge 1 commit into
superagent.method(...args, callback)#6shesek wants to merge 1 commit into
Conversation
Owner
|
Didn’t know about this usage. Can you add tests for this? Also follow the current code style (e.g. semicolons) |
Otherwise, the request is already sent by the time we apply the plugins with `request.use()`.
Author
|
Force-pushed the requested changes. The tests required some creativity to get it not to actually send the requests out, by overriding |
Author
|
Is using arrow functions in the tests considered okay? Just noticed that I'm breaking the convention with that too... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
superagent.method(...args, callback)currently fails to properly apply the plugins, because the request is already sent by the time the plugins are applied withuse(). This patch fixes that.