feat: Implemented - Autofill skills using github#100
Conversation
|
@MohamedAazil is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
komalharshita
left a comment
There was a problem hiding this comment.
Great feature contribution overall — this enhancement fits the project very well and improves onboarding/user experience meaningfully.
Things done well:
- Clean GitHub skill import flow
- Reuse of existing
addSkill()infrastructure - Good modal UX and loading states
- Deduplication using
Set - Proper issue linking and testing documentation
- Scoped changes with no unnecessary files modified
A few small issues should be addressed before merge:
- Potential null reference issue in
script.js
The event listeners are attached directly after:
document.getElementById(...)If these elements are unavailable on another page using the same script bundle, this may throw runtime errors. Please wrap the GitHub modal logic with null checks like:
if (openModalBtn && modal) {
...
}- There appears to be an extra closing brace:
} // end isDetailPage
} // end isDetailPagePlease verify the structure and remove any accidental duplicate closure.
- Error handling can be improved:
errorMsg.textContent = err;This may show [object Object]. Prefer:
err.message || "Failed to fetch skills"Other than those minor fixes, this is a strong and useful feature contribution.
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for addressing all the requested changes.
The null-check protection has been implemented correctly, the duplicate brace issue is resolved, and the error handling is now much cleaner and safer for users.
The feature is well-scoped, integrates nicely with the existing skill system, and provides a meaningful UX improvement for onboarding.
Looks good to merge.
Summary [required]
Implemented the feature that allows the user to fetch top skills from their github profile.
Related Issue [required]
Closes #46
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
| File | Change made |
| index.html | Added github import button and modal|
| .gitignore | To ignore the environment files |
| script.js | Functionality to fetch the repo skill information and add to skills list|
| style.css | Added styles for the new modal and button |
How to Test This PR [required]
git checkout your-branch-namepip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results [required]
PASS test_projects_json_loads
PASS test_each_project_has_required_fields
PASS test_find_project_by_id_found
PASS test_find_project_by_id_missing
PASS test_parse_skills_basic
PASS test_parse_skills_empty_string
PASS test_parse_skills_single_entry
PASS test_score_single_project_full_match
PASS test_score_single_project_no_match
PASS test_get_recommendations_returns_results
PASS test_get_recommendations_max_three
PASS test_get_recommendations_no_match_returns_empty
PASS test_get_recommendations_result_format
PASS test_validate_all_valid
PASS test_validate_missing_skills
PASS test_validate_missing_level
PASS test_validate_missing_interest
PASS test_validate_missing_time
PASS test_validate_all_missing
PASS test_home_route
PASS test_recommend_api_valid
PASS test_recommend_api_missing_field
PASS test_recommend_api_empty_body
PASS test_project_detail_found
PASS test_project_detail_not_found
PASS test_view_code_found
PASS test_download_code_found
27 passed, 0 failed out of 27 tests
Screenshots (if UI change)
Before

After
DevPath.Find.Projects.Based.On.Your.Skills.-.Google.Chrome.2026-05-15.17-55-50.mp4
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
This feature only gets the top skill from each of the users projects, we could extend it further by fetching all the skills from all repos or asking the user from which all repos the user would like to fetch skills. This can be done as an enhancement as part of a seperate issue.