feat: implement dynamic project statistics section#122
Conversation
|
@SATYAM-PRATIBHAN is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@komalharshita please do review and tell me if need some changes, so that we can close this issue ASAP. |
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the detailed implementation and for keeping the changes well-scoped. This is a strong feature contribution overall — especially the backend integration, responsive handling, and dynamic rendering approach.
I reviewed the feature carefully and there are two important improvements needed before merge:
- The metric labelled as “Skill Categories” is currently calculated using the count of unique skills/technologies:
len(all_skills)This does not actually represent categories. Please either:
- rename the label to something more accurate like “Unique Skills”, “Technologies”, or “Skills Covered”
OR - implement proper category grouping logic.
- The statistics now appear twice on the homepage:
- once in the hero stat strip,
- and again in the new statistics cards section.
This creates visual duplication and weakens hierarchy. Please refine the UX by either:
- replacing the existing hero stats,
- removing the duplicate section,
- or ensuring both sections present different information.
Once these improvements are addressed, this PR will be in a much stronger state for merge.
|
@komalharshita you can check the changes now |
komalharshita
left a comment
There was a problem hiding this comment.
Thanks for addressing the requested changes.
The statistics labeling is now accurate, and removing the duplicated hero stat strip significantly improves the page hierarchy and overall UX. The implementation feels much cleaner and more polished after the revisions.
The dynamic stats section is responsive, well-structured, and integrates nicely with the existing design system.
Looks good to merge now.
Summary [required]
Implemented a dynamic statistics section on the homepage to provide users with an immediate overview of the project repository.
Related Issue [required]
Closes #26
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
utils/data_loader.pyget_project_stats()to dynamically calculate metrics from the project dataset.routes/main_routes.pyindexroute to fetch and pass project statistics to the homepage template.templates/index.htmlstatic/style.cssHow to Test This PR [required]
git checkout feat/dynamic-stats-responsivenesspip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results [required]
Screenshots (if UI change)
| Before |


| After |
Self-Review Checklist [required]
feat/dynamic-stats-responsivenesspython tests/test_basic.pyand logic-related tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
The two test failures (
test_view_code_foundandtest_download_code_found) are existing environment issues due to missing files in thestarter_code/directory and are unrelated to the changes in this PR. All core logic and UI routing tests for the homepage and statistics passed successfully.