perf(data_loader): cache JSON data in memory to avoid repeated disk reads#13
Open
Alm0stSurely wants to merge 1 commit intokomalharshita:mainfrom
Open
perf(data_loader): cache JSON data in memory to avoid repeated disk reads#13Alm0stSurely wants to merge 1 commit intokomalharshita:mainfrom
Alm0stSurely wants to merge 1 commit intokomalharshita:mainfrom
Conversation
…eads Implements a simple module-level cache for projects.json to eliminate repeated disk I/O on every call to load_all_projects(). Changes: - Add _projects_cache module variable - Modify load_all_projects() to use cache after first read - Add clear_cache() function for test isolation - Update tests to call clear_cache() in setup_module() - Add benchmark script showing 847x speedup Fixes komalharshita#11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
As described in #11, utils/data_loader.py currently reads projects.json from disk on every call to load_all_projects().
Solution
Implemented in-memory cache with module-level variable:
Benchmarks
Testing
All 25 tests pass.
Fixes #11