feat: personalise <title> tag on project detail page with level and skill#156
Open
Harshada-Yele wants to merge 2 commits into
Open
feat: personalise <title> tag on project detail page with level and skill#156Harshada-Yele wants to merge 2 commits into
Harshada-Yele wants to merge 2 commits into
Conversation
|
@Harshada-Yele is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Hi @komalharshita |
Owner
|
@Harshada-Yele kindly resolve the merge conflicts |
Contributor
Author
|
Hi @komalharshita |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The project detail page
<title>tag previously rendered asProject Name — DevPath, which is functional but misses an SEOopportunity. This PR updates the title in
templates/project.htmlto include the project's difficulty level and primary skill/interest
area, making pages more discoverable for users searching for specific
project ideas (e.g. "Beginner Python projects"). A Jinja2
{% if %}guard is included to handle projects with an empty skills list safely.
Related Issue
Closes #84
Type of Change
data/projects.jsonWhat Was Changed
templates/project.html<title>tag to includeproject.levelandproject.skills[0]with an{% if project.skills %}guardHow to Test This PR
git checkout feat/personalise-project-detail-titlepip install -r requirements.txtpython app.pyhttp://127.0.0.1:5000and navigate to any project detail pagePersonal Expense Tracker — Beginner Python Project | DevPathinstead of
Personal Expense Tracker — DevPathpython tests/test_basic.pyExpected test output:
27 passed, 0 failed out of 27 tests
Test Results
|


|
|
Self-Review Checklist
feat/personalise-project-detail-titlepython tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
The only file changed is
templates/project.html— one line. No Pythonlogic, no routes, no data files were touched. The
{% if project.skills %}guard ensures the title renders gracefully even if a project entry has an
empty or missing skills list.