Refactor README formatting and content#164
Conversation
Updated README to improve formatting and content structure.
|
@Dippp10-ally is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@komalharshita ji , do merge my above pull request 164 that closes issue number 105...do assign gssoc:approved and level:intermediate labels to issue number 105 and pull request number 164 |
komalharshita
left a comment
There was a problem hiding this comment.
Thank you for the effort put into this PR. The README improvements show good initiative and a strong attempt to improve project presentation and contributor onboarding.
However, this PR cannot be merged in its current state because there are several major issues that need to be addressed first:
-
The linked issue appears incorrect and does not match the scope of the changes made. (include issue without space eg. Closes #issue_number)
- Please link the correct issue related to the README/documentation refactor.
-
The PR template contains unrelated information:
utils/recommender.pytests/test_basic.py
These files were not modified in this PR.
-
The PR introduces placeholder/broken content:
https://your-demo-link.comdocs/images/devpath-preview.png(image asset not included)
-
Several technical claims were added without verification:
- “Startup time under 1 second”
- “O(n) recommendation scoring”
Please avoid adding unverified engineering claims.
-
Important existing documentation sections were removed or heavily reduced:
- route documentation
- contributor workflow details
- onboarding guidance
- dataset extension details
-
Some markdown formatting appears malformed and may break README rendering.
Because this PR significantly restructures the entire README, it needs to be more carefully scoped and aligned with the existing project documentation standards.
Please revise the PR accordingly and resubmit the changes in a more focused and validated form.
|
@komalharshita ji , I have modified the link to issue , ,such as wording closes#105 are now together..... Thank you for the detailed review and constructive feedback. I understand the concerns raised regarding the scope, documentation accuracy, and formatting consistency of the README refactor. I’ll revise the PR accordingly before resubmitting. Planned fixes include:
I’ll also reduce the scope of the PR to keep the changes more focused and aligned with the project’s documentation standards. Thank you again for the review and guidance. |
Updated README to improve formatting and content structure.
Summary [required]
Related Issue [required]
Closes #105
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
clear_cache()functionHow to Test This PR [required]
git checkout your-branch-namepip install -r requirements.txtpython app.pypython tests/test_basic.pyExpected test output:
Test Results [required]
Screenshots (if UI change)
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer