Fix skill parsing for skill names containing commas#265
Open
jwalkorat wants to merge 1 commit into
Open
Conversation
|
@jwalkorat is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a bug where skill names containing commas were parsed incorrectly.
Previously, skills were stored as comma-separated strings. This caused problems when a skill itself contained commas, such as
"HTML, CSS".This PR updates the frontend to send skills using
JSON.stringify()and updates the backend parser to safely reconstruct the original skill array usingjson.loads().A fallback for the previous comma-separated format was also added to maintain backward compatibility.
Related Issue
Closes #188
Type of Change
What Was Changed
static/script.jsJSON.stringify()utils/recommender.pyHow to Test This PR
Run the app:
python app.py
Open:
http://127.0.0.1:5000
Add a skill containing commas
Example:
HTML, CSS
Generate recommendations
Verify that:
Test Results
Tested manually in browser.
Self-Review Checklist
Notes for Reviewer
This implementation fixes the parsing issue without changing the overall recommendation architecture and keeps support for older comma-separated skill formats.