fix: resolve broken external links and missing target handling in learning resources (#245)#266
Open
mithilP007 wants to merge 1 commit into
Open
fix: resolve broken external links and missing target handling in learning resources (#245)#266mithilP007 wants to merge 1 commit into
mithilP007 wants to merge 1 commit into
Conversation
|
@mithilP007 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR standardizes how project learning-resource links are parsed and rendered so external resources open safely in a new tab with appropriate security attributes.
Changes:
- Added a reusable
parse_external_linkhelper for extracting labels and URLs. - Registered a
parse_resourceJinja filter through the main routes blueprint. - Updated the project detail template and added helper unit tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
utils/link_helper.py |
Adds link parsing utility for resource strings. |
routes/main_routes.py |
Registers the helper as a Jinja template filter. |
templates/project.html |
Uses parsed link metadata to render resource links safely. |
tests/test_basic.py |
Adds unit coverage for the new link helper. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
Solved under Gssoc2026 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #245 by introducing a robust link helper utility to safely parse and standardize external link handling, registering a custom Jinja filter 'parse_resource' to handle formatting, and updating 'templates/project.html' to render resource links with appropriate target and rel attributes. Additionally, unit tests were added to verify the helper logic.