fix: resolve missing pytest fixture in test_health_check#274
Closed
anshul23102 wants to merge 2 commits into
Closed
fix: resolve missing pytest fixture in test_health_check#274anshul23102 wants to merge 2 commits into
anshul23102 wants to merge 2 commits into
Conversation
_projects_cache was declared but load_all_projects() never read or wrote it, causing a redundant disk read on every request. Added double-checked locking with threading.Lock so the JSON file is read once and reused safely across concurrent requests. clear_cache() now acquires the same lock before resetting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@anshul23102 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
Bot
added
gssoc-2026
type:bug
test_health_check(client) declared a 'client' parameter expecting a pytest fixture that was never defined. Every other test in the suite uses the local get_client() helper instead. The error caused the entire test run to report an ERROR and the health endpoint was never actually tested.
anshul23102
force-pushed
the
fix/test-health-check-fixture
branch
from
d832302 to
dd96f52
Compare
Author
|
Closing in favour of a cleaner PR with only the relevant commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #273
What was wrong
test_health_check(client)declaredclientas a parameter, expecting a pytest fixture that was never defined anywhere in the test file. Every other test uses the localget_client()helper directly. This caused pytest to report anERRORon every run, meaning the/healthendpoint was never actually tested.What changed
Removed the
clientparameter and addedclient = get_client()inside the function body, consistent with all other tests in the file.Tests
Type of change