feat: Add <noscript> fallback message for users with JavaScript disabled#276
Open
Harshada-Yele wants to merge 1 commit into
Open
feat: Add <noscript> fallback message for users with JavaScript disabled#276Harshada-Yele wants to merge 1 commit into
Harshada-Yele wants to merge 1 commit into
Conversation
|
@Harshada-Yele is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
Hi @komalharshita Note: test_health_check has a pre-existing fixture bug unrelated to this PR. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a
<noscript>fallback message totemplates/index.htmlso thatusers with JavaScript disabled see a clear explanation instead of a silently
broken form.
The warning banner is styled in
static/style.cssusing existingCSS custom properties and appears directly below the navbar. Without this change, the skill chip input system renders but is completely non-functional for
JS-disabled users with no feedback shown.
Related Issue [required]
Closes #256
Type of Change
data/projects.jsonWhat Was Changed
templates/index.html<noscript>block below<nav>to display fallback message when JS is disabledstatic/style.css.noscript-warningclass styled with warning colours andmargin-top: 64pxto account for fixed navbar heightHow to Test This PR
git checkout feat/noscript-fallbackpip install -r requirements.txtpython app.pychrome://settings/content/javascript127.0.0.1:5000http://127.0.0.1:5000— you should see a yellow warning banner below the navbar127.0.0.1:5000from the blocked list and reload — banner should disappearpytest tests/test_basic.py -k "not test_health_check"Expected test output:
Test Results
Screenshots
Self-Review Checklist
feat/noscript-fallbackpytest tests/test_basic.pyand 29 tests passprint()orconsole.log()debug statementsNotes for Reviewer
The
<noscript>tag is placed between the<nav>and<section class="hero">so it appears at the top of the page content. The
margin-top: 64pxin CSSaccounts for the fixed navbar height to prevent the banner being hidden behind it.
Note:
test_health_checkhas a pre-existing fixture bug unrelated to this PR.A separate issue should be raised for it.