style: improve navbar hover underline animation#282
Open
pari-dubey1 wants to merge 1 commit into
Open
Conversation
|
@pari-dubey1 is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
@komalharshita Hi! I’ve completed the changes in this PR. Everything has been tested locally and is working properly now. Could you please review and merge this PR into the main branch when you get a chance? Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary [required]
Added a smoother and more modern animated underline hover effect for navbar links to improve visual feedback and overall navigation interactivity.
The underline animation now expands from the center with a 75% width effect, creating a cleaner and more polished UI experience.
Also fixed the mobile hamburger menu visibility issue caused during styling updates.
Related Issue [required]
Closes #215
Type of Change [required]
data/projects.jsonWhat Was Changed [required]
static/style.cssHow to Test This PR [required]
Clone this branch:
git checkout style/navbar-hover-underlineInstall dependencies:
pip install -r requirements.txtRun the app:
python app.pyOpen:
http://127.0.0.1:5000Hover over navbar links and verify:
Run the tests:
python tests/test_basic.pyExpected output:
Test Results [required]
Screenshots (if UI change)
Before:
After:
Self-Review Checklist [required]
feat/,fix/,docs/,data/,style/,test/python tests/test_basic.pyand all 27 tests passflake8 .locally and there are no errorsprint()orconsole.log()debug statementsNotes for Reviewer
This PR only updates navbar styling and hover interactions. No application logic or backend functionality was modified.